Add IO to OpenEducation methodology #75

Mihnea0Firoiu · 2024-08-05T00:19:38Z

Prerequisite Checklist

Read the contribution guidelines regarding submitting new changes to the project;
Tested your changes against relevant architectures and platforms;
Updated relevant documentation (if needed).

Description of changes

teodutu

Check my comments to see some easy first fixes and also why the build fails. Then when it passes I'll make a more in-depth review.

Move the task descriptions from the reading/ files to each task's README.md
Remove references to the common makefiles (.../common/makefile/*.mk). Copy their content to each makefile that includes them so the tasks don't depend on outside resources.

teodutu · 2024-08-11T03:47:19Z

chapters/io/client-server-model/drills/tasks/client-server/README.md

Don't forget to add the task description to this README file.

teodutu · 2024-08-11T04:18:43Z

chapters/io/io-internals/drills/tasks/buffering/support/libc_buffering.c

@@ -0,0 +1,79 @@
+/* SPDX-License-Identifier: BSD-3-Clause */


Suggested change

/* SPDX-License-Identifier: BSD-3-Clause */

// SPDX-License-Identifier: BSD-3-Clause

Use // for SPDX tags in .c files and /* ... */ for .hs.

teodutu · 2024-08-11T04:19:04Z

chapters/io/io-internals/drills/tasks/buffering/support/printf_buffering.c

@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: BSD-3-Clause */


Suggested change

/* SPDX-License-Identifier: BSD-3-Clause */

// SPDX-License-Identifier: BSD-3-Clause

teodutu · 2024-08-11T04:19:46Z

chapters/io/io-internals/drills/tasks/buffering/support/no_buffering.c

@@ -0,0 +1,74 @@
+/* SPDX-License-Identifier: BSD-3-Clause */


Suggested change

/* SPDX-License-Identifier: BSD-3-Clause */

// SPDX-License-Identifier: BSD-3-Clause

teodutu · 2024-08-11T04:21:10Z

chapters/io/local-io-in-action/drills/tasks/simple-file-operations/support/Makefile

+BINARIES = file_operations directory_operations
+include ../../../../../common/makefile/multiple.mk


Remove refernces to global makefiles.

teodutu · 2024-08-11T04:24:24Z

chapters/io/pipes/drills/tasks/receive-challenges/support/Makefile

+BINARIES = send_fd_4 receive_pipe send_fifo receive_fifo send_unix_socket receive_unix_socket send_net_dgram_socket receive_net_dgram_socket
+include ../../../../../common/makefile/multiple.mk


Ditto: Remove references to external makefiles.

teodutu · 2024-08-11T04:33:35Z

chapters/io/io-multiplexing/reading/io-multiplexing.md

+   student@os:~/.../lab/multiplex/support$ make
   gcc -g -Wall -Wextra -I../../../../../common/makefile/..  -c -o epoll_echo_server.o epoll_echo_server.c
   gcc -g -Wall -Wextra -I../../../../../common/makefile/..  -c -o ../../../../../common/makefile/../utils/log/log.o ../../../../../common/makefile/../utils/log/log.c
   gcc -g -Wall -Wextra -I../../../../../common/makefile/..  -c -o ../../../../../common/utils/sock/sock_util.o ../../../../../common/utils/sock/sock_util.c


After making the makefiles standalone, re-run these make commands and paste the new output here.

teodutu · 2024-08-11T04:36:55Z

chapters/io/io-internals/reading/io-internals.md

 2. Now, it is interesting to see how we can force libc to dump that internal buffer.
 The most direct way is by using the `fflush()` library call, which is made for this exact purpose.
 But we can be more subtle.


Suggested change

2. Now, it is interesting to see how we can force libc to dump that internal buffer.

The most direct way is by using the `fflush()` library call, which is made for this exact purpose.

But we can be more subtle.

1. Now, it is interesting to see how we can force libc to dump that internal buffer.

The most direct way is by using the `fflush()` library call, which is made for this exact purpose.

But we can be more subtle.

Suggested change

2. Now, it is interesting to see how we can force libc to dump that internal buffer.

The most direct way is by using the `fflush()` library call, which is made for this exact purpose.

But we can be more subtle.

Add a `\n` in some of the strings printed in `buffering/support/printf_buffering.c`.

Place them wherever you want (at the beginning, end, or middle).

Recompile the code and observe its change in behaviour under `strace`.

You don't need to disable MD029 above. Remove the comment above that disables this rule and add a tab to each new line within the same numbered list item to keep the rendered numbering correct. Do the same for the list item above.

teodutu · 2024-08-11T04:37:22Z

chapters/io/io-internals/reading/io-internals.md

+Add a `\n` in some of the strings printed in `buffering/support/printf_buffering.c`.
 Place them wherever you want (at the beginning, at the end, in the middle).
 Recompile the code and observe its change in behaviour under `strace`.

 <!-- markdownlint-enable MD029 -->


Suggested change

Add a `\n` in some of the strings printed in `buffering/support/printf_buffering.c`.

Place them wherever you want (at the beginning, at the end, in the middle).

Recompile the code and observe its change in behaviour under `strace`.



Add a `\n` in some of the strings printed in `buffering/support/printf_buffering.c`.

Place them wherever you want (at the beginning, end, or middle).

Recompile the code and observe its change in behaviour under `strace`.

teodutu · 2024-08-11T04:57:00Z

chapters/io/arena/drills/tasks/mini-shell/support/Makefile

This link is broken. That's why the build fails.

Signed-off-by: Mihnea Firoiu <[email protected]>

teodutu

The build fails because chapters/io/arena/drills/tasks/mini-shell/ is missing its support/ folder which causes the Makefile symlink to point to an invalid path.

teodutu · 2024-09-27T07:53:50Z

chapters/io/file-mappings/drills/tasks/file-mappings/support/benchmark_cp.sh

@@ -0,0 +1,19 @@
+#! /bin/bash
+


Suggested change

# SPDX-License-Identifier: BSD-3-Clause

teodutu · 2024-09-29T16:14:51Z

chapters/io/remote-io/drills/tasks/receive-challenges/support/Makefile

Remove the include and copy-paste the contents of the included makefile here so the task doesn't have outside dependencies.

teodutu · 2024-09-29T16:15:29Z

chapters/io/remote-io/drills/tasks/send-receive/support/receiver.py

+
+IP = "127.0.0.1"  # Loopback IP address (localhost)
+MAX_MESSAGE_LENGTH = 1024
+PORT = 5000  # Port to listen for data data on (non-privileged ports are > 1023)


Suggested change

PORT = 5000 # Port to listen for data data on (non-privileged ports are > 1023)

PORT = 5000 # Port to listen for data (non-privileged ports are > 1023)

github-actions bot added area/reading Update to reading content area/tasks Update to tasks kind/new New content / item labels Aug 5, 2024

teodutu marked this pull request as ready for review August 5, 2024 15:53

teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Aug 5, 2024

Mihnea0Firoiu force-pushed the Mihnea0Firoiu/IO branch from a351b9b to d84d43a Compare August 6, 2024 14:43

teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Aug 11, 2024

teodutu requested changes Aug 11, 2024

View reviewed changes

Add IO to OpenEducation methodology

18a5278

Signed-off-by: Mihnea Firoiu <[email protected]>

Mihnea0Firoiu force-pushed the Mihnea0Firoiu/IO branch from d84d43a to 18a5278 Compare September 22, 2024 17:17

teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Sep 27, 2024

teodutu reviewed Sep 29, 2024

View reviewed changes

teodutu requested changes Sep 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add IO to OpenEducation methodology #75

Add IO to OpenEducation methodology #75

Mihnea0Firoiu commented Aug 5, 2024 •

edited

Loading

teodutu left a comment

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu Aug 11, 2024

teodutu left a comment

teodutu Sep 27, 2024

teodutu Sep 29, 2024

teodutu Sep 29, 2024

	/* SPDX-License-Identifier: BSD-3-Clause */
	// SPDX-License-Identifier: BSD-3-Clause

		BINARIES = file_operations directory_operations
		include ../../../../../common/makefile/multiple.mk

		BINARIES = send_fd_4 receive_pipe send_fifo receive_fifo send_unix_socket receive_unix_socket send_net_dgram_socket receive_net_dgram_socket
		include ../../../../../common/makefile/multiple.mk

	PORT = 5000 # Port to listen for data data on (non-privileged ports are > 1023)
	PORT = 5000 # Port to listen for data (non-privileged ports are > 1023)

Add IO to OpenEducation methodology #75

Are you sure you want to change the base?

Add IO to OpenEducation methodology #75

Conversation

Mihnea0Firoiu commented Aug 5, 2024 • edited Loading

Prerequisite Checklist

Description of changes

teodutu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teodutu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mihnea0Firoiu commented Aug 5, 2024 •

edited

Loading