Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve Container CI/CD #24

Open
RJMurg opened this issue Sep 8, 2024 · 1 comment · May be fixed by #40
Open

[Enhancement] Improve Container CI/CD #24

RJMurg opened this issue Sep 8, 2024 · 1 comment · May be fixed by #40
Assignees
@RJMurg
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
CI/CD

Comments

@RJMurg
Copy link
Member

RJMurg commented Sep 8, 2024

Currently the ENTIRE repo is pulled onto HDL to be built as a container, then redeployed.

A significantly better solution is as follows:

  • All GH Action tests run in PR and pass
  • GH Action runs in main to verify with SonarQube
  • Once SonarQube passes, GH Action runs to build container on GitHub Container Registry (GHCR)
  • HDL has container (Watchtower?) that sees change and pulls down JUST the image & redeploys new image
@RJMurg RJMurg added enhancement New feature or request good first issue Good for newcomers labels Sep 8, 2024
@RJMurg RJMurg added this to the CI/CD milestone Sep 8, 2024
@RJMurg RJMurg self-assigned this Sep 8, 2024
@RJMurg
Copy link
Member Author

RJMurg commented Oct 8, 2024

Would also be a really good idea to only have the GH Actions run if there is changes to the source code, or any of the required scaffolding (Dockerfiles, .dockerignore, etc.) changes.

README.md, LICENSE.md, etc. changes should not require a new container build.

This was referenced Oct 16, 2024
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RJMurg RJMurg

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
CI/CD
Development

Successfully merging a pull request may close this issue.

[⚙️🐳] Added image build action cs-soc-tudublin/Plume
1 participant
@RJMurg