Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Github Action to verify container can build first before deploying. #8

Closed
RJMurg opened this issue Aug 2, 2024 · 2 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@RJMurg
Copy link
Member

RJMurg commented Aug 2, 2024

Add CI/CD step where container is test build first (dry run?) before deployment.
If it fails, it should not even SSH.

This will increase deployment times, but only by a few minutes at maximum. Container build time is ~1 minute.

@RJMurg RJMurg added this to the CI/CD milestone Sep 3, 2024
@RJMurg RJMurg added the enhancement New feature or request label Sep 3, 2024
@RJMurg
Copy link
Member Author

RJMurg commented Oct 8, 2024

I think it would be better if we built the container to the GHCR instead of building it on the machine itself.
Means we don't have to clone the entire repo, and instead just pull the container image from the GHCR.

There are 3 ways that I'm thinking of that we could use to automate deployment after a container build:

  • Webhook to something like Jenkins that pulls down the image and deploys it
  • A GH Action that runs after the container is built to SSH in and recomposes up
  • A container like Watchtower (or alternative) which constantly looks for new images for any Container running [image]:latest.

@cs-soc-tudublin/system-administrators We should chat about this this week

@RJMurg
Copy link
Member Author

RJMurg commented Oct 16, 2024

Closed in #39
The check runs at PR time as opposed to deployment time

@RJMurg RJMurg closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant