Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "locktime" and "ownername" to cs3 lock api #213

Open
kobergj opened this issue Aug 28, 2023 · 2 comments
Open

Add "locktime" and "ownername" to cs3 lock api #213

kobergj opened this issue Aug 28, 2023 · 2 comments

Comments

@kobergj
Copy link
Contributor

kobergj commented Aug 28, 2023

The lock object should be enhanced with two new optional values:

  • "ownername": The name of the lock owner. This is an enhancement so clients do not have to query for the owner name.
  • "locktime": The time the lock was created. Additionally to "expiry" this gives more information to the clients.

See discussion in poc PR: cs3org/reva#4133

See lock object on current main: https://github.com/cs3org/cs3apis/blob/main/cs3/storage/provider/v1beta1/resources.proto#L159-L180

@labkode
Copy link
Member

labkode commented Aug 28, 2023

@glpatcern

@glpatcern
Copy link
Member

From the discussion in the referenced PR, I understand that:

  • For the ownername, it really seems an optimization due to lack of caching of the web layer. As such, an opaque extra value for now makes sense, whereas promoting this to a field seems sub-optimal. At least, it introduces room for contradictions if ownername does not correspond to the username of user, and that alone IMHO is a reason not to add this value.
  • For the locktime, I don't have a very strong opinion. @tbsbdr mentioned that exposing the expirationtime is totally fine for web. @butonic do we really have an added value in specifying both values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants