Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eosclient: Handle removal of favorites #5016

Open
labkode opened this issue Dec 18, 2024 · 0 comments
Open

eosclient: Handle removal of favorites #5016

labkode opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@labkode
Copy link
Member

labkode commented Dec 18, 2024

When removing the last favorite for a file, the key remains with an empty value:

... other attributes elided ...
user.http://owncloud.org/ns/favorite=""

The problem is due to the way the serialization is performed, using the acl utils:
https://github.com/cs3org/reva/blob/master/pkg/eosclient/eosbinary/eosbinary.go#L507

This fix should be performed both on eosclientbinary and eosgrpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants