Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI to harden the code #57

Open
2 of 4 tasks
glpatcern opened this issue Jan 20, 2022 · 3 comments
Open
2 of 4 tasks

CI to harden the code #57

glpatcern opened this issue Jan 20, 2022 · 3 comments
Labels

Comments

@glpatcern
Copy link
Member

glpatcern commented Jan 20, 2022

Similarly to the Reva repo, we should add a CI to at least:

  • pylint the code
  • run the unit tests against a local filesystem
  • run the unit tests with the cs3 flavor against a live Reva daemon
  • run the WOPI validator test suite against a live WOPI server connected to a live Reva daemon

This should be activated as usual to any PR against the master branch - as well as any direct commit to master.

@glpatcern glpatcern self-assigned this Jan 20, 2022
@glpatcern glpatcern added the CI label Jan 20, 2022
@glpatcern
Copy link
Member Author

The "easy" standalone part was integrated successfully. Keeping the issue open for the test against a live Reva daemon.

@glpatcern
Copy link
Member Author

As discussed with @javfg, we should use a custom GitHub runner similarly to what @vascoguita has setup for Reva, such that a live Reva daemon is in place and two containers are created: the wopiserver one and the WOPI validator one. TBC.

@micbar
Copy link
Member

micbar commented May 16, 2023

the ocis project has the WOPI Validator running in the CI

This is an example https://drone.owncloud.com/owncloud/ocis/22470/46/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants