Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WebDriverIntegrationBuilderExtensions for SRP #231

Open
craigfowler opened this issue Nov 8, 2024 · 0 comments
Open

Refactor WebDriverIntegrationBuilderExtensions for SRP #231

craigfowler opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement A feature enhancement
Milestone

Comments

@craigfowler
Copy link
Member

Imported from Selenium issue #62

The file WebDriverIntegrationBuilderExtensions currently exposes a number of mechanisms by which a web driver may be registered to a Screenplay integration. This ticket is to split up some of that functionality so that it may be used piecemeal. The motivation for this change is so that it is easier to write custom scenarios in which parts of that common logic (currently in the file) are desired, but other parts are not.

One example which has been found recently is the desire to have custom requested capabilities injected into the web driver, chosen at runtime. This required copying the existing code into the consuming project, in order to achieve the requirement. Instead, it would have been better if the parts which we did want to reuse were reusable independently, and only a few changes needed to be made to the DI config.

@craigfowler craigfowler added the enhancement A feature enhancement label Nov 8, 2024
@craigfowler craigfowler added this to the v2.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature enhancement
Projects
None yet
Development

No branches or pull requests

1 participant