From 0d6ad49b6182f2844621bb92894ff08524715465 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Thu, 28 Nov 2024 09:09:58 +0100 Subject: [PATCH] ci: drop linux/arm/v7 from the platforms for building container-images There is not need for `secrets.BUILD_PLATFORMS`, as the platforms are not confidential. Instead a variable has been created in the GitHub repository settings for it now. The `secrets.BUILD_PLATFORMS` includes linux/arm/v7, which is a slow and phased out architecture. All reasonable ARM platforms are linux/arm64 now. Dropping the linux/arm/v7 platform makes building the container images much faster. Closes: #719 Signed-off-by: Niels de Vos --- .github/workflows/build-push.yaml | 4 ++-- .github/workflows/test-build.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-push.yaml b/.github/workflows/build-push.yaml index 857719c35..000512c08 100644 --- a/.github/workflows/build-push.yaml +++ b/.github/workflows/build-push.yaml @@ -65,7 +65,7 @@ jobs: with: context: . file: Dockerfile - platforms: ${{ secrets.BUILD_PLATFORMS }} + platforms: ${{ vars.BUILD_PLATFORMS }} push: true tags: quay.io/csiaddons/k8s-controller:latest @@ -95,6 +95,6 @@ jobs: with: context: . file: build/Containerfile.sidecar - platforms: ${{ secrets.BUILD_PLATFORMS }} + platforms: ${{ vars.BUILD_PLATFORMS }} push: true tags: quay.io/csiaddons/k8s-sidecar:latest diff --git a/.github/workflows/test-build.yaml b/.github/workflows/test-build.yaml index 472b3ab6e..1a1087464 100644 --- a/.github/workflows/test-build.yaml +++ b/.github/workflows/test-build.yaml @@ -52,7 +52,7 @@ jobs: with: context: . file: Dockerfile - platforms: ${{ secrets.BUILD_PLATFORMS }} + platforms: ${{ vars.BUILD_PLATFORMS }} push: false tags: quay.io/csiaddons/k8s-controller:latest @@ -74,6 +74,6 @@ jobs: with: context: . file: build/Containerfile.sidecar - platforms: ${{ secrets.BUILD_PLATFORMS }} + platforms: ${{ vars.BUILD_PLATFORMS }} push: false tags: quay.io/csiaddons/k8s-sidecar:latest