Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftwareTrigger is in the wrong module #2607

Open
kosack opened this issue Aug 21, 2024 · 1 comment
Open

SoftwareTrigger is in the wrong module #2607

kosack opened this issue Aug 21, 2024 · 1 comment

Comments

@kosack
Copy link
Contributor

kosack commented Aug 21, 2024

I just noticed that SoftwareTrigger is in the instrument module, which is not the right place for it. Instrument is for the software model that describes the hardware, not for algorithms. It should go into its own module perhaps.

This could happen during the larger module refactoring in CEP-4 #2489

This is also related to #2606 , where we might want to have a selectable set of algorithms for software triggering.

@GernotMaier
Copy link
Contributor

As a side note, is this really required for prod6 and beyond? There should be flag set describing the trigger type and one would select those events only with LST hardware trigger set (to e.g., suppress the few mono LST trigger in the simulation files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants