Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event source is not compatible with data produced by latest EVB where number of gains can depend on event type #15

Open
sizun opened this issue Jun 11, 2021 · 4 comments

Comments

@sizun
Copy link
Contributor

sizun commented Jun 11, 2021

In the current NectarCAMEventSource, the number of gains n_gains is an argument constructor and is assumed to be the same for all events. Also it could be derived from the source.camera_config.nectarcam.algorithms parameter.

Since switching to version 4 of the event builder, this parameter is no longer filled as gain selection is enabled or not depending on the event type.

Maybe we should look how LSTEventSource handled the transition.

@jlenain
Copy link
Contributor

jlenain commented May 28, 2024

Just to check, I think this issue has been addressed and is obsolete now, is that correct ?

@maxnoe
Copy link
Member

maxnoe commented May 28, 2024

Looking at the code in __init__.py, it seems like you correctly check on an event-by-event basis if the event was gain selected or not

@vmarandon
Copy link
Contributor

Yes, but I would love to try on realistic data before closing this issue :-)
(Including mixture of high-gain pixels and low-gain selected pixels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants