From c29478ed9678ad1dcae7508dc0195fb94a689e6c Mon Sep 17 00:00:00 2001
From: Sam Hughes <sam@cube.dev>
Date: Sun, 29 Sep 2024 22:26:35 -0700
Subject: [PATCH] refactor: Removed MetadataCacheFactory::build_writer_props

---
 datafusion/src/physical_plan/parquet.rs | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/datafusion/src/physical_plan/parquet.rs b/datafusion/src/physical_plan/parquet.rs
index 5a1fe88d942c..df46b0faca1a 100644
--- a/datafusion/src/physical_plan/parquet.rs
+++ b/datafusion/src/physical_plan/parquet.rs
@@ -43,7 +43,6 @@ use arrow::{
 };
 use hashbrown::HashMap;
 use log::debug;
-use parquet::file::properties::{WriterProperties, WriterPropertiesBuilder};
 use parquet::file::{
     footer,
     metadata::RowGroupMetaData,
@@ -141,7 +140,6 @@ pub trait ParquetMetadataCache: Debug + Sync + Send {
     }
 }
 
-// TODO: Rename to ParquetMetadataCacheFactory?  Rename for build_writer_props field?
 /// Constructs the desired types of caches for Parquet Metadata.
 pub trait MetadataCacheFactory: Sync + Send {
     /// Makes a noop cache (which doesn't cache)
@@ -152,13 +150,6 @@ pub trait MetadataCacheFactory: Sync + Send {
         max_capacity: u64,
         time_to_idle: Duration,
     ) -> Arc<dyn ParquetMetadataCache>;
-    /// Modifies and builds writer properties.
-    fn build_writer_props(
-        &self,
-        builder: WriterPropertiesBuilder,
-    ) -> Result<WriterProperties> {
-        Ok(builder.build())
-    }
 }
 
 /// Default MetadataCache, does not cache anything