Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space needed between algorithm and code #303

Open
rokicki opened this issue Nov 17, 2023 · 2 comments
Open

Space needed between algorithm and code #303

rokicki opened this issue Nov 17, 2023 · 2 comments
Labels
🐞 bug Something isn't working Twizzle

Comments

@rokicki
Copy link
Contributor

rokicki commented Nov 17, 2023

Steps to reproduce the issue

Visit the URL:

https://alpha.twizzle.net/explore/?alg=U+F+R%2F%2F+comment

Observed behaviour

The algorithm and comment are completely ignored and the URL is rewritten to drop these args.

🖼 Screenshots

No response

Expected behaviour

A space should not be required before a comment.

Browser & operating system

Chrome on MacOS

Additional info

(Found by Christopher Mowla; turned into an issue by Tom.)

@rokicki rokicki added 🐞 bug Something isn't working Twizzle labels Nov 17, 2023
@lgarron
Copy link
Member

lgarron commented Nov 17, 2023

It looks like this is about two separate things?

  • We require whitespace between alg nodes. I want to keep this the same — mandatory whitespace sets a much better interoperability baseline for all other apps.
  • Twizzle Explorer ignores invalid URL alg parameters — we can consider showing an error message.

@rokicki
Copy link
Contributor Author

rokicki commented Nov 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working Twizzle
Projects
None yet
Development

No branches or pull requests

2 participants