Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon fonts are no longer encouraged? #28

Open
jfly opened this issue May 2, 2017 · 2 comments
Open

Icon fonts are no longer encouraged? #28

jfly opened this issue May 2, 2017 · 2 comments

Comments

@jfly
Copy link
Member

jfly commented May 2, 2017

See https://github.com/blog/2112-delivering-octicons-with-svg and https://css-tricks.com/icon-fonts-vs-svg/.

https://24ways.org/2014/an-overview-of-svg-sprite-creation-techniques/ described a neat sprite solution that didn't work in safari back in 2014 (hopefully it's working now?

Other articles about this:

Maybe we can provide a svg sprite as well as a font based solution for folks? It would be nice if whatever we do doesn't actually change the "api" to use our icons.

@jfly
Copy link
Member Author

jfly commented Aug 26, 2018

@lgarron, I feel like you are our most tuned in web developer. Do you have any thoughts on this? I did a bunch of reading on this topic, and while everyone agrees that icon fonts are not the way to go anymore, nobody had advice about how a library such as ours should actually switch to svg fonts. Currently our users are able to simply include a single css file, and they're good to go. I would really like to keep things that simple for them if at all possible.

@lgarron
Copy link
Member

lgarron commented Aug 26, 2018

I'd say the font works well enough; no reason to discontinue it. People can still use SVGs if they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants