Try a dynamically sized array for orientation_packer.

[lgarron]

Per:

twsearch/src/rs/packed/orientation_packer.rs

Lines 7 to 13 in c01a33d

	// TODO: Avoid using this to hardcode the outer size of `transformation_lookup`.
	// Setting `MAX_NUM_ORIENTATIONS` is usually way larger than necessary, although
	// the wasted space is only ≈25KB per orbit. Ideally, we should allow
	// `transformation_lookup` to be much smaller by using another direct allocation
	// (without taking the performance hit of `Vec`, which is noticeable in this
	// situation).
	const MAX_NUM_ORIENTATIONS: usize = 107;

// TODO: Avoid using this to hardcode the outer size of transformation_lookup.
// Setting MAX_NUM_ORIENTATIONS is usually way larger than necessary, although
// the wasted space is only ≈25KB per orbit. Ideally, we should allow
// transformation_lookup to be much smaller by using another direct allocation
// (without taking the performance hit of Vec, which is noticeable in this
// situation).

Using Vec<[PackedOrientationWithMod; NUM_BYTE_VALUES]> for transformation_lookup has a noticeable negative impact on performance, so that's not a good option. (This was changed in fe3a859.)

We already use a pointer-based u8 array for PackedKState, so we could possibly adapt that.

[lgarron]

Using Vec<[PackedOrientationWithMod; NUM_BYTE_VALUES]> for transformation_lookup has a noticeable negative impact on performance, so that's not a good option. (This was changed in fe3a859.)

Actually, this might not be true! I'm running benchmarks again and it might be within normal variability.

Still worth trying, since it wouldn't take that long to experiment.