Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fatal: No names found, cannot describe anything. in CI #9

Open
lgarron opened this issue May 14, 2023 · 0 comments
Open

Avoid fatal: No names found, cannot describe anything. in CI #9

lgarron opened this issue May 14, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lgarron
Copy link
Member

lgarron commented May 14, 2023 •
edited
Loading

twsearch/Makefile

Line 21 in aed70f8

TWSEARCH_VERSION=$(shell git describe --tags)
causes CI to warn:

fatal: No names found, cannot describe anything.

This is because the checkout is shallow and does not include the last tag. We can either update our use actions/checkout or use an alternative way to store/calculate the versions.
@lgarron lgarron added enhancement New feature or request good first issue Good for newcomers labels May 14, 2023
lgarron added a commit that referenced this issue May 14, 2023
@lgarron
Fall back to current commit hash as version string.
53301a5 
Addresses #9
@lgarron lgarron mentioned this issue Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgarron