Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normal Sampler Parameters for SDXL #92

Open
drmbt opened this issue Sep 22, 2024 · 5 comments
Open

normal Sampler Parameters for SDXL #92

drmbt opened this issue Sep 22, 2024 · 5 comments

Comments

@drmbt
Copy link

drmbt commented Sep 22, 2024

loving sampler parameters with grid, wish ive always had this. It doesn't work with non flux though, could you fork this node to work with SDXL? Would also love params as a dict instead of a string, would be easier to pull a key from there

@cubiq
Copy link
Owner

cubiq commented Sep 22, 2024

yeah it's totally doable, I was thinking of doing one node that works with all models, but it's a lot of work 😄... I'll think of something

@drmbt
Copy link
Author

drmbt commented Sep 23, 2024

another RFE would just be an any input for PlotParameters to be able to accept arbitrary user determined information, could be appended, and params input could be optional

@cubiq
Copy link
Owner

cubiq commented Sep 23, 2024

that's a good idea

@drmbt
Copy link
Author

drmbt commented Sep 25, 2024

If you do end up with one KSampler to rule them all, a huge request would be a params output with a breakout node to be able to further pipe any of that data downstream, for example to put the steps, cfg, sampler and inference run time in the filename. a dictionary out and the option to pull a single key would be very useful

@drmbt
Copy link
Author

drmbt commented Oct 31, 2024

I know you're probably busy as hell right now, but with SD3.5 hitting the scene, it would be awesome if Sampler Parameters were adapted to support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants