Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change doc for junit5 #487

Open
toepi opened this issue Jun 21, 2020 · 7 comments
Open

change doc for junit5 #487

toepi opened this issue Jun 21, 2020 · 7 comments
Labels
language: java ⚡ enhancement Request for new functionality

Comments

@toepi
Copy link

toepi commented Jun 21, 2020

have found the the documention is a little outdate to use cucumber with junit5, it reference to junit-vintage-engine. with is only correct if cucumber-junit will be used. since cucumber 5 it is possible to use junit5 native with cucumber-junit-platform-engine.

Why no pr? I'm unsure how to describe it in a good manner. Have only found out that the current stand is confusing new users.

@mlvandijk mlvandijk added ⚡ enhancement Request for new functionality language: java labels Oct 6, 2020
@mlvandijk
Copy link
Member

Hi @toepi - Thanks you for creating this issue. Would you be open to collaborating on a PR? You can get started by changing the things you have found to be outdated and people can review / add suggestion?

@mpkorstanje
Copy link
Contributor

@mlvandijk I'm waiting for junit-team/junit5#2416. Once implemented we'll be feature complete with Junit 4.

@mlvandijk
Copy link
Member

Good to know, thnx @mpkorstanje

@jimshowalter
Copy link

Is there even a sketch somewhere of how to use native JUnit 5 with cucumber-junit-platform-engine while excluding junit and the vintage engine? We added cucumber-junit-platform-engine and excluded junit and the vintage engine, and now it runs but says there are no tests. Adding back the vintage engine, it finds our tests. A working example posted to some public repo somewhere would be extremely useful, in lieu of documentation.

@jimshowalter
Copy link

jimshowalter commented Feb 4, 2021

Here's a working example. I cloned it, added excludes of junit and vintage engine, and it still works: https://github.com/cronn/cucumber-junit5-example

@mpkorstanje
Copy link
Contributor

@jimshowalter
Copy link

I'd read that, but nothing beats a checked-in, working example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language: java ⚡ enhancement Request for new functionality
Projects
None yet
Development

No branches or pull requests

4 participants