From fd86524216bcaa9cea01c40ef9c48bb3387726db Mon Sep 17 00:00:00 2001
From: Kevin Yank <thatguy@kevinyank.com>
Date: Tue, 12 Sep 2023 14:09:50 +1000
Subject: [PATCH 1/2] chore(rich-text-editor)!: Rename value to defaultValue
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

To conform to React naming convention for form control props.
Uncontrolled form fields take a `defaultValue` to indicate that
changes to this prop's value will not update the mounted component.
Rather, the component manages its current value as internal state,
and notifies subscribers via onChange when it changes.

Consumers will need to update their code to the new prop name. E.g. before:

```jsx
<RichTextEditor value={…}>
```

and after:

```jsx
<RichTextEditor defaultValue={…}>
```
---
 .changeset/fluffy-camels-applaud.md           | 23 +++++++++++++++++++
 .../docs/EditableRichTextContent.stories.tsx  |  2 +-
 .../docs/RichTextEditor.stories.tsx           | 12 +++++-----
 .../RichTextEditor.spec.stories.tsx           |  2 +-
 .../RichTextEditor/RichTextEditor.spec.tsx    |  9 +++++---
 .../src/RichTextEditor/RichTextEditor.tsx     |  9 ++++----
 6 files changed, 42 insertions(+), 15 deletions(-)
 create mode 100644 .changeset/fluffy-camels-applaud.md

diff --git a/.changeset/fluffy-camels-applaud.md b/.changeset/fluffy-camels-applaud.md
new file mode 100644
index 0000000..5142490
--- /dev/null
+++ b/.changeset/fluffy-camels-applaud.md
@@ -0,0 +1,23 @@
+---
+"@kaizen/rich-text-editor": major
+---
+
+Rename `value` prop to reflect uncontrolled form field
+
+To conform to React naming convention for form control props.
+Uncontrolled form fields take a `defaultValue` to indicate that
+changes to this prop's value will not update the mounted component.
+Rather, the component manages its current value as internal state,
+and notifies subscribers via `onChange` when it changes.
+
+Consumers will need to update their code to the new prop name. E.g. before:
+
+```jsx
+<RichTextEditor value={…}>
+```
+
+and after:
+
+```jsx
+<RichTextEditor defaultValue={…}>
+```
diff --git a/packages/rich-text-editor/docs/EditableRichTextContent.stories.tsx b/packages/rich-text-editor/docs/EditableRichTextContent.stories.tsx
index be237ce..5e93257 100644
--- a/packages/rich-text-editor/docs/EditableRichTextContent.stories.tsx
+++ b/packages/rich-text-editor/docs/EditableRichTextContent.stories.tsx
@@ -60,7 +60,7 @@ function InlineEditor(props: {
             { name: "bulletList", group: "list" },
             { name: "link", group: "link" },
           ]}
-          value={rteData}
+          defaultValue={rteData}
           onChange={handleOnChange}
         />
         <Box mt={0.5} style={{ display: "flex", justifyContent: "end" }}>
diff --git a/packages/rich-text-editor/docs/RichTextEditor.stories.tsx b/packages/rich-text-editor/docs/RichTextEditor.stories.tsx
index 3c8de1b..6e86e34 100644
--- a/packages/rich-text-editor/docs/RichTextEditor.stories.tsx
+++ b/packages/rich-text-editor/docs/RichTextEditor.stories.tsx
@@ -9,7 +9,7 @@ import dummyContent from "./dummyContent.json"
 import dummyMalformedContent from "./dummyMalformedContent.json"
 
 type RTEStory = StoryFn<
-  Omit<RichTextEditorProps, "value" | "onChange" | "aria-labelledby">
+  Omit<RichTextEditorProps, "defaultValue" | "onChange" | "aria-labelledby">
 >
 
 export default {
@@ -32,7 +32,7 @@ export const Default: RTEStory = ({ labelText, ...args }) => {
   return (
     <RichTextEditor
       labelText={labelText}
-      value={rteData}
+      defaultValue={rteData}
       onChange={handleOnChange}
       {...args}
     />
@@ -60,7 +60,7 @@ export const WithData: RTEStory = ({ labelText, ...args }) => {
   return (
     <RichTextEditor
       labelText={labelText}
-      value={rteData}
+      defaultValue={rteData}
       onChange={handleOnChange}
       {...args}
     />
@@ -89,7 +89,7 @@ export const WithBadData: RTEStory = ({ labelText, ...args }) => {
   return (
     <RichTextEditor
       labelText={labelText}
-      value={rteData}
+      defaultValue={rteData}
       onChange={handleOnChange}
       {...args}
     />
@@ -121,14 +121,14 @@ export const WithDescriptionAndValidationMessage: RTEStory = ({
     <>
       <RichTextEditor
         labelText={labelText}
-        value={rteData}
+        defaultValue={rteData}
         onChange={handleOnChange}
         status="error"
         {...args}
       />
       <RichTextEditor
         labelText={labelText}
-        value={rteData}
+        defaultValue={rteData}
         onChange={handleOnChange}
         status="caution"
         {...args}
diff --git a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.stories.tsx b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.stories.tsx
index 9298002..2ab9bea 100644
--- a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.stories.tsx
+++ b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.stories.tsx
@@ -21,7 +21,7 @@ const TestBase: Story = {
     return (
       <RichTextEditor
         labelText="Label"
-        value={rteData}
+        defaultValue={rteData}
         onChange={handleOnChange}
         rows={3}
         controls={[
diff --git a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.tsx b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.tsx
index 5943cd4..b474315 100644
--- a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.tsx
+++ b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.spec.tsx
@@ -18,8 +18,11 @@ const getSelectionOfNode = (node: Node): void => {
 }
 
 const TestRTE = (
-  args: Omit<RichTextEditorProps, "value" | "onChange" | "aria-labelledby"> & {
-    rteMockData?: RichTextEditorProps["value"]
+  args: Omit<
+    RichTextEditorProps,
+    "defaultValue" | "onChange" | "aria-labelledby"
+  > & {
+    rteMockData?: RichTextEditorProps["defaultValue"]
   }
 ): JSX.Element => {
   const { rteMockData, ...rest } = args
@@ -34,7 +37,7 @@ const TestRTE = (
         { name: "orderedList", group: "list" },
         { name: "bulletList", group: "list" },
       ]}
-      value={rteData}
+      defaultValue={rteData}
       onChange={handleOnChange}
       {...rest}
     />
diff --git a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.tsx b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.tsx
index 017dff9..a13c33b 100644
--- a/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.tsx
+++ b/packages/rich-text-editor/src/RichTextEditor/RichTextEditor.tsx
@@ -23,10 +23,10 @@ import styles from "./RichTextEditor.module.scss"
 
 export interface BaseRichTextEditorProps
   extends OverrideClassName<
-    Omit<HTMLAttributes<HTMLDivElement>, "onChange" | "content">
+    Omit<HTMLAttributes<HTMLDivElement>, "onChange" | "defaultValue">
   > {
   onChange: (content: ProseMirrorState.EditorState) => void
-  value: EditorContentArray
+  defaultValue: EditorContentArray
   controls?: ToolbarItems[]
   /**
    * Sets a default min-height for the editable area in units of body paragraph line height, similar to the 'rows' attribute on <textarea>.
@@ -64,7 +64,7 @@ export type RichTextEditorProps = RTEWithLabelText | RTEWithLabelledBy
 export const RichTextEditor = (props: RichTextEditorProps): JSX.Element => {
   const {
     onChange,
-    value,
+    defaultValue,
     labelText,
     "aria-labelledby": labelledBy,
     classNameOverride,
@@ -93,7 +93,8 @@ export const RichTextEditor = (props: RichTextEditorProps): JSX.Element => {
             type: "doc",
             // we're converting empty arrays to the ProseMirror default "empty" state because when
             // given an empty array ProseMirror returns undefined, breaking the type
-            content: value?.length > 0 ? value : [{ type: "paragraph" }],
+            content:
+              defaultValue?.length > 0 ? defaultValue : [{ type: "paragraph" }],
           }),
           schema,
           plugins: getPlugins(controls, schema),

From ae623f738069cdacc3d260af991be72196d2b25c Mon Sep 17 00:00:00 2001
From: Kevin Yank <thatguy@kevinyank.com>
Date: Tue, 12 Sep 2023 14:35:30 +1000
Subject: [PATCH 2/2] chore: Ignore TS build output in eslint check

---
 .eslintignore | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/.eslintignore b/.eslintignore
index 2c3cc1f..e994683 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -1 +1,9 @@
-/packages/**/dist
\ No newline at end of file
+/packages/**/dist
+/draft-packages/**/*.js
+/draft-packages/**/*.js.map
+/draft-packages/**/*.d.ts
+/packages/**/*.js
+!/packages/**/*.config.js
+!/packages/**/svgMock.js
+/packages/**/*.js.map
+/packages/**/*.d.ts