Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tricrypto get_dy implementation #214

Closed
chanhosuh opened this issue Sep 5, 2023 · 2 comments · Fixed by #259
Closed

Tricrypto get_dy implementation #214

chanhosuh opened this issue Sep 5, 2023 · 2 comments · Fixed by #259
Assignees
@allt0ld
Labels
priority: medium
Milestone
0.5.5

Comments

@chanhosuh
Copy link
Member

Currently CurveCryptoPool.get_dy does not handle 3 coins, only 2. Update the implementation in a clean manner to handle this. Similar test as for 2 coins should work. Reference implementation is the Tricrypto-NG vyper fixture.
@chanhosuh chanhosuh added this to the 0.5.5 milestone Sep 5, 2023
@allt0ld
Copy link
Collaborator

allt0ld commented Sep 6, 2023

Fixes #148

@chanhosuh
Copy link
Member Author

Fixes #148

Actually #148 doesn't need get_dy, it needs get_y, which is implemented now. Also, i think probably the price scale needs to be used to make sure the axis range is correct.

@allt0ld allt0ld mentioned this issue Sep 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allt0ld allt0ld

Labels
priority: medium
Projects
None yet
Milestone
0.5.5
Development

Successfully merging a pull request may close this issue.

Tricrypto get dy curveresearch/curvesim
2 participants
@chanhosuh @allt0ld