Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tricrypto remove_liquidity_one_coin #218

Closed
chanhosuh opened this issue Sep 5, 2023 · 1 comment · Fixed by #283
Closed

Tricrypto remove_liquidity_one_coin #218

chanhosuh opened this issue Sep 5, 2023 · 1 comment · Fixed by #283
Labels
priority: medium
Milestone
0.5.5

Comments

@chanhosuh
Copy link
Member

Currently CurveCryptoPool.remove_liquidity_one_coin does not handle 3 coins, only 2. Update the implementation in a clean manner to handle this. Similar test as for 2 coins should work. Reference implementation is the Tricrypto-NG vyper fixture.

Note: This is blocked by calc_withdraw_one_coin.
@chanhosuh chanhosuh added this to the 0.5.5 milestone Sep 5, 2023
@allt0ld
Copy link
Collaborator

allt0ld commented Oct 5, 2023 •
edited
Loading

Tricrypto claims admin fees before withdrawal (L772), but cryptopool doesn't. This difference links this issue to #231

@allt0ld allt0ld mentioned this issue Nov 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium
Projects
None yet
Milestone
0.5.5
Development

Successfully merging a pull request may close this issue.

Tricrypto remove_liquidity_one_coin and remove_liquidity curveresearch/curvesim
2 participants
@chanhosuh @allt0ld