Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurveCryptoPool.__init__ bugs #219

Closed
chanhosuh opened this issue Sep 5, 2023 · 0 comments · Fixed by #234
Closed

CurveCryptoPool.__init__ bugs #219

chanhosuh opened this issue Sep 5, 2023 · 0 comments · Fixed by #234
Assignees
@chanhosuh
Labels
bug Something isn't working
Milestone
0.5.0rc

Comments

@chanhosuh
Copy link
Member

  • need to use the generalized newton_D function to handle 3 coins when D is not passed in
  • self.virtual_price = 10**18 * xcp // tokens fails when tokens is None
@chanhosuh chanhosuh added the bug Something isn't working label Sep 5, 2023
@chanhosuh chanhosuh added this to the 0.5.5 milestone Sep 5, 2023
@nagakingg nagakingg mentioned this issue Sep 6, 2023
Closed
@chanhosuh chanhosuh mentioned this issue Sep 7, 2023
Merged
3 tasks
@chanhosuh chanhosuh self-assigned this Sep 7, 2023
@chanhosuh chanhosuh modified the milestones: 0.5.5, 0.5.0rc Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chanhosuh chanhosuh

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0rc
Development

Successfully merging a pull request may close this issue.

Crypto pool init fixes curveresearch/curvesim
1 participant
@chanhosuh