Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pool balancing in factory function #221

Closed
2 tasks
chanhosuh opened this issue Sep 5, 2023 · 0 comments · Fixed by #239
Closed
2 tasks

Handle pool balancing in factory function #221

chanhosuh opened this issue Sep 5, 2023 · 0 comments · Fixed by #239
Assignees
Milestone

Comments

@chanhosuh
Copy link
Member

chanhosuh commented Sep 5, 2023

Remove D computation from the pool snapshot. It is only needed for creating balanced pools. This should be done explicitly in the factory function get_sim_pool. The regular get_pool doesn't appear to need this extra functionality so we can remove the balancing options from that.

Fixes #220.

Let's do this as 2 PRs to be safe:

  • fix for stableswap first (check tests still pass)
  • fix for cryptoswap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant