Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple coins (at least 3 because of tricrypto) #91

Closed
3 tasks done
Tracked by #87 ...
chanhosuh opened this issue Feb 6, 2023 · 2 comments · Fixed by #159
Closed
3 tasks done
Tracked by #87 ...

Handle multiple coins (at least 3 because of tricrypto) #91

chanhosuh opened this issue Feb 6, 2023 · 2 comments · Fixed by #159
Assignees
Labels
enhancement New feature or request priority: medium

Comments

@chanhosuh
Copy link
Member

chanhosuh commented Feb 6, 2023

Factory pools are 2 coins but the code is mostly generic enough to handle more, e.g. tricrypto. A few places in the copied vyper factory contract highlights where the n-coin logic was changed to 2 coins. Those should likely be the only changes needed. For testing, we should use two vyper contracts based on n = 2 or 3: 1) existing fixture based on factory cryptopool 2) tricrypto2 fixture

Todo:

  • create tricrypto2 fixture
  • create test suite for n=3 checking against tricrypto fixture
  • update CryptoPool to handle n=3
@chanhosuh
Copy link
Member Author

@chanhosuh chanhosuh self-assigned this May 18, 2023
@chanhosuh chanhosuh added this to the Cryptopool Sims milestone Jun 23, 2023
@chanhosuh chanhosuh mentioned this issue Jul 5, 2023
14 tasks
@chanhosuh
Copy link
Member Author

For now, we just need to test that swaps work properly to enable sims. The more complex logic in adding and removing liquidity can be checked later, as part of an eventual release for full pythonic interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant