Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision icons jumping around #16

Open
harry-wood opened this issue Sep 30, 2017 · 1 comment
Open

Collision icons jumping around #16

harry-wood opened this issue Sep 30, 2017 · 1 comment

Comments

@harry-wood
Copy link

With the collisions map markers, in addition to this issue, these markers jump around randomly.

jumping-collision-markers

Is that deliberate?

@mvl22
Copy link
Member

mvl22 commented Sep 30, 2017

Currently there is jittering enabled, which causes this.

It's an attempt to deal with the issue that the original resolution of the data (which is an OS grid reference, not a lat-lon) means that often more than one collision happens in one place. As a result, Leaflet.js would only show one of them as they're in the same location.

https://www.cyclestreets.net/api/v2/collisions.locations/

See the jitter parameter. As noted there, the current implementation is recognised as not perfect. The solution is basically that we jitter once up-front rather than than on-request.

Another solution is clustering though personally in general I'm not a fan of that. I'd welcome views!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants