feat(backend): handle two modules owning the same resource #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petar-cvit
requested changes
May 9, 2024
There was a problem hiding this comment.
You should check for the label value in the Reconcile function. It is responsible for deploying all resources from templates. And also this does not only apply to Deployments, but to all K8s services deployed by the controler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Fixes #163
📑 Description
This PR solves the issue of handling two modules having the same resources.
Solution
Added a check before creating if any value of label
cyclops.Modulematches with the current name of the Module. If return false then return with error.✅ Checks
ℹ Additional context