Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Deployment logs #341

Open
petar-cvit opened this issue Jun 16, 2024 · 6 comments
Open

Filter Deployment logs #341

petar-cvit opened this issue Jun 16, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers UI Update on the UI

Comments

@petar-cvit
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Cyclops shows logs for running pods here. Scope of the task is to add a search for logs that you can use to filter out the log you are looking for.

Describe the solution you'd like
Add a search bar to the top of the logs modal and show all logs that contain the search input.

@petar-cvit petar-cvit added good first issue Good for newcomers UI Update on the UI labels Jun 16, 2024
@doncicuto
Copy link
Contributor

Hi @petar-cvit would the search box that comes with React Ace would fit your need?

image

@petar-cvit
Copy link
Collaborator Author

@doncicuto Actually yeah, I actually searched for something out of the box like this, but didn't find it. Exactly what we need. Could you open a PR for it?

@doncicuto
Copy link
Contributor

Perfect @petar-cvit you can assign the issue to me then and do you want the Search button to show for every React Ace editor or just for the one for Deployment logs?

@petar-cvit
Copy link
Collaborator Author

Just the one with the logs will do

@petar-cvit
Copy link
Collaborator Author

Hey @doncicuto, do you have any updates on the issue?

@doncicuto
Copy link
Contributor

Next week I'll prepare a PR, sorry for the delay, busy summer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI Update on the UI
Projects
None yet
Development

No branches or pull requests

2 participants