Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload after xtrigger arg change #6259

Closed
hjoliver opened this issue Jul 23, 2024 · 2 comments · Fixed by #6263
Closed

reload after xtrigger arg change #6259

hjoliver opened this issue Jul 23, 2024 · 2 comments · Fixed by #6263
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 23, 2024

Reportedly, cylc vr on a running workflow (i.e., reload) does not update the clock trigger time. Stopping the scheduler first (i.e., restart) does get it right.

[UPDATE]
Confirmed, using a minimal example:

[scheduling]
    initial cycle point = now
    [[xtriggers]]
       # x = wall_clock(offset=P0Y)
        x = wall_clock(offset=P1Y)
    [[graph]]
        PT1M = "@x => foo"
[runtime]
    [[foo]]
@hjoliver hjoliver added the bug? Not sure if this is a bug or not label Jul 23, 2024
@hjoliver hjoliver added this to the 8.3.x milestone Jul 23, 2024
@hjoliver hjoliver added bug Something is wrong :( and removed bug? Not sure if this is a bug or not labels Jul 25, 2024
@hjoliver
Copy link
Member Author

I think this probably affects all xtriggers, not just clock-triggers.

Draft fix posted.

@hjoliver hjoliver self-assigned this Jul 25, 2024
@hjoliver hjoliver changed the title reload after clock-trigger time change reload after xtrigger arg change Jul 25, 2024
@MetRonnie MetRonnie linked a pull request Jul 25, 2024 that will close this issue
8 tasks
@MetRonnie MetRonnie modified the milestones: 8.3.x, 8.3.4 Jul 25, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.4, 8.3.5 Sep 11, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.5, 8.3.6 Oct 14, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.6, 8.3.7 Oct 18, 2024
@hjoliver hjoliver modified the milestones: 8.3.7, 8.3.6 Nov 11, 2024
@hjoliver
Copy link
Member Author

Closed by #6263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants