Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc lint mistakenly picks up PBS -W directive as LSF time limit directive #6550

Open
MetRonnie opened this issue Jan 10, 2025 · 5 comments
Open
Assignees
Labels
bug Something is wrong :( small
Milestone

Comments

@MetRonnie
Copy link
Member

Description

The -W option allows for the specification of additional job attributes.

https://www.jlab.org/hpc/PBS/qsub.html

Reproducible Example

[runtime]
  [[foo]]
    platform = pbs_platform
    [[[directives]]]
      -W umask = 0022

Expected Behaviour

cylc lint S014 should look for -W = for LSF rather than just -W

@MetRonnie MetRonnie added bug Something is wrong :( small labels Jan 10, 2025
@MetRonnie MetRonnie added this to the 8.4.1 milestone Jan 10, 2025
@wxtim wxtim self-assigned this Jan 10, 2025
@wxtim
Copy link
Member

wxtim commented Jan 10, 2025

I suspect that this would require us to save more state to allow us to differentiate between PBS and LSF jobs, in a similar way to #6348.

The quicker solution is to artificially remove -W from the list of wallclock directives to check for.

Do we want to do this?

Are any of the others problematic in a similar way?

{
  "loadleveler": "wall_clock_limit",
  "lsf": "-W",
  "moab": "-l walltime",
  "pbs": "-l walltime",
  "pbs_multi_cluster": "-l walltime",
  "sge": "-l h_rt",
  "slurm": "--time",
  "slurm_packjob": "--time"
}

@MetRonnie
Copy link
Member Author

MetRonnie commented Jan 10, 2025

cylc lint S014 should look for -W = for LSF rather than just -W

Is this not feasible? It doesn't need any more state than the current line

@wxtim
Copy link
Member

wxtim commented Jan 10, 2025

cylc lint S014 should look for -W = for LSF rather than just -W

Is this not feasible? It doesn't need any more state than the current line

I'm not sure what you mean - that I can narrow the scope of the regex to only include valid values for LSF?

@MetRonnie
Copy link
Member Author

MetRonnie commented Jan 10, 2025

The difference between LSF's -W and PBS's -W:

  • LSF: -W = 10
  • PBS: -W something = 10

@wxtim
Copy link
Member

wxtim commented Jan 10, 2025

That's what I worked out. Working on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

No branches or pull requests

2 participants