Apply CLI clean changes to correct list #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.sys-argv-cleaner
branch
from
10240aa
to
8efc72a
Compare
MetRonnie
requested review from
MetRonnie
and removed request for
oliver-sanders
|
I've changed the base branch to 8.2.x to match the milestone |
MetRonnie
reviewed
Mar 12, 2024
Co-authored-by: Ronnie Dutta <[email protected]>
MetRonnie
approved these changes
Mar 13, 2024
oliver-sanders
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an otherwise unrecorded bug reported by @matthewrmshin .
To Reproduce
Ensure that Cylc will attempt remote reinvocation (
global.cylc[scheduler][run hosts]availableis set to >=1 remote host).Should result in...
$ cylc play # Cylc VIP listing command with arguments. .... cylc: error: Wrong number of arguments (too few)Cause
cleanup_sysargvwas modifyingsys.argvbefore over-writing it with a new list of args.Reviewers should
Aside from usual checks reviewers should check this change against cylc-rose tests: The original report involved a rose option config.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect usersCylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.Bug fix does not require docs beyond change log.?.?.xbranch.