Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate job submissions. #6337

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix duplicate job submissions. #6337

merged 2 commits into from
Aug 29, 2024

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Aug 29, 2024

Close #6329

In the example of 6329 an upstream failure generates a bunch of partially satisfied tasks - i.e. active (n=0) but not queued. Triggering them manually causes them to be added to a forced_released list - wrongly as they were not queued in the first place.

A bit later, the forced_released tasks top up the list of naturally released tasks. But by then there is some overlap between the two lists, so the queue limit matters (along with some task-state related race condition which I haven't fully understood, but that doesn't matter) as to how many of these tasks end up getting submitted again.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Aug 29, 2024
@hjoliver hjoliver self-assigned this Aug 29, 2024
@hjoliver hjoliver added this to the 8.3.4 milestone Aug 29, 2024
@hjoliver hjoliver marked this pull request as ready for review August 29, 2024 07:12
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nice simple fix, makes sense, cannot reproduce on this branch.

Changelog entry wouldn't hurt.

@wxtim wxtim merged commit 1c5db24 into cylc:8.3.x Aug 29, 2024
27 checks passed
@hjoliver hjoliver deleted the fix-dupl-submit branch September 1, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants