-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit use of multiple subscription sockets/threads #194
Comments
This was referenced Mar 26, 2024
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Mar 28, 2024
* Closes cylc#194 * Run subscribers via asyncio rather than the ThreadPoolExecutor. * The only non-blocking operations in the code being called were: - time.sleep (has an async variant) - asyncio.sleep (async) - self.socket.recv_multipart (async) * Refactored the code so that the underlying async functions could be called via asyncio.
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Mar 28, 2024
* Closes cylc#194 * Run subscribers via asyncio rather than the ThreadPoolExecutor. * The only non-blocking operations in the code being called were: - time.sleep (has an async variant) - asyncio.sleep (async) - self.socket.recv_multipart (async) * Refactored the code so that the underlying async functions could be called via asyncio.
8 tasks
I've had a crack at removing the thread pool and running the subscribers via asyncio, seems to work: #574 |
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Apr 22, 2024
* Closes cylc#194 * Run subscribers via asyncio rather than the ThreadPoolExecutor. * The only non-blocking operations in the code being called were: - time.sleep (has an async variant) - asyncio.sleep (async) - self.socket.recv_multipart (async) * Refactored the code so that the underlying async functions could be called via asyncio.
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this issue
Apr 22, 2024
* Closes cylc#194 * Run subscribers via asyncio rather than the ThreadPoolExecutor. * The only non-blocking operations in the code being called were: - time.sleep (has an async variant) - asyncio.sleep (async) - self.socket.recv_multipart (async) * Refactored the code so that the underlying async functions could be called via asyncio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found here:
https://zguide.zeromq.org/docs/chapter2/#Plugging-Sockets-into-the-Topology
And further down:
Can we reduce the need for multi-threaded UIS by using one subscription socket with multiple connections? (to every publisher/Scheduler)
The text was updated successfully, but these errors were encountered: