From b2c895daaa01c833b6a40fca060e547d210fee42 Mon Sep 17 00:00:00 2001
From: Solomon White <rubysolo@gmail.com>
Date: Tue, 12 Mar 2024 08:18:32 -0600
Subject: [PATCH] fix: lint errors (#802)

Fixes #661
---
 .eslintrc                                     |   2 -
 cypress/e2e/2-advanced-examples/actions.cy.js | 116 +++++++++++-------
 cypress/e2e/2-advanced-examples/cookies.cy.js |   3 +-
 cypress/e2e/2-advanced-examples/misc.cy.js    |   3 +-
 .../spies_stubs_clocks.cy.js                  |   3 +
 cypress/e2e/2-advanced-examples/storage.cy.js |  49 ++++----
 .../e2e/2-advanced-examples/utilities.cy.js   |   9 +-
 7 files changed, 108 insertions(+), 77 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index 851cc6563..470346329 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -14,8 +14,6 @@
   },
   "rules": {
     "indent": ["error", 2, { "SwitchCase": 1, "MemberExpression": "off" }],
-    // TODO: remove after https://github.com/cypress-io/cypress-example-kitchensink/issues/661 has been resolved
-    "cypress/unsafe-to-chain-command": "off",
     "mocha/no-exclusive-tests": "error",
     "mocha/no-mocha-arrows": "off"
   }
diff --git a/cypress/e2e/2-advanced-examples/actions.cy.js b/cypress/e2e/2-advanced-examples/actions.cy.js
index d9fe5e52f..aa0e44a3e 100644
--- a/cypress/e2e/2-advanced-examples/actions.cy.js
+++ b/cypress/e2e/2-advanced-examples/actions.cy.js
@@ -9,50 +9,51 @@ context('Actions', () => {
 
   it('.type() - type into a DOM element', () => {
     // https://on.cypress.io/type
-    cy.get('.action-email')
-      .type('fake@email.com').should('have.value', 'fake@email.com')
+    cy.get('.action-email').type('fake@email.com')
+    cy.get('.action-email').should('have.value', 'fake@email.com')
 
-      // .type() with special character sequences
-      .type('{leftarrow}{rightarrow}{uparrow}{downarrow}')
-      .type('{del}{selectall}{backspace}')
+    // .type() with special character sequences
+    cy.get('.action-email').type('{leftarrow}{rightarrow}{uparrow}{downarrow}')
+    cy.get('.action-email').type('{del}{selectall}{backspace}')
 
-      // .type() with key modifiers
-      .type('{alt}{option}') //these are equivalent
-      .type('{ctrl}{control}') //these are equivalent
-      .type('{meta}{command}{cmd}') //these are equivalent
-      .type('{shift}')
+    // .type() with key modifiers
+    cy.get('.action-email').type('{alt}{option}') //these are equivalent
+    cy.get('.action-email').type('{ctrl}{control}') //these are equivalent
+    cy.get('.action-email').type('{meta}{command}{cmd}') //these are equivalent
+    cy.get('.action-email').type('{shift}')
 
-      // Delay each keypress by 0.1 sec
-      .type('slow.typing@email.com', { delay: 100 })
-      .should('have.value', 'slow.typing@email.com')
+    // Delay each keypress by 0.1 sec
+    cy.get('.action-email').type('slow.typing@email.com', { delay: 100 })
+    cy.get('.action-email').should('have.value', 'slow.typing@email.com')
 
     cy.get('.action-disabled')
       // Ignore error checking prior to type
       // like whether the input is visible or disabled
       .type('disabled error checking', { force: true })
-      .should('have.value', 'disabled error checking')
+    cy.get('.action-disabled').should('have.value', 'disabled error checking')
   })
 
   it('.focus() - focus on a DOM element', () => {
     // https://on.cypress.io/focus
     cy.get('.action-focus').focus()
-      .should('have.class', 'focus')
+    cy.get('.action-focus').should('have.class', 'focus')
       .prev().should('have.attr', 'style', 'color: orange;')
   })
 
   it('.blur() - blur off a DOM element', () => {
     // https://on.cypress.io/blur
-    cy.get('.action-blur').type('About to blur').blur()
-      .should('have.class', 'error')
+    cy.get('.action-blur').type('About to blur')
+    cy.get('.action-blur').blur()
+    cy.get('.action-blur').should('have.class', 'error')
       .prev().should('have.attr', 'style', 'color: red;')
   })
 
   it('.clear() - clears an input or textarea element', () => {
     // https://on.cypress.io/clear
     cy.get('.action-clear').type('Clear this text')
-      .should('have.value', 'Clear this text')
-      .clear()
-      .should('have.value', '')
+    cy.get('.action-clear').should('have.value', 'Clear this text')
+    cy.get('.action-clear').clear()
+    cy.get('.action-clear').should('have.value', '')
   })
 
   it('.submit() - submit a form', () => {
@@ -61,7 +62,7 @@ context('Actions', () => {
       .find('[type="text"]').type('HALFOFF')
 
     cy.get('.action-form').submit()
-      .next().should('contain', 'Your form has been submitted!')
+    cy.get('.action-form').next().should('contain', 'Your form has been submitted!')
   })
 
   it('.click() - click on a DOM element', () => {
@@ -97,13 +98,13 @@ context('Actions', () => {
     // that controls where the click occurs :)
 
     cy.get('#action-canvas')
-      .click(80, 75) // click 80px on x coord and 75px on y coord
-      .click(170, 75)
-      .click(80, 165)
-      .click(100, 185)
-      .click(125, 190)
-      .click(150, 185)
-      .click(170, 165)
+    cy.get('#action-canvas').click(80, 75) // click 80px on x coord and 75px on y coord
+    cy.get('#action-canvas').click(170, 75)
+    cy.get('#action-canvas').click(80, 165)
+    cy.get('#action-canvas').click(100, 185)
+    cy.get('#action-canvas').click(125, 190)
+    cy.get('#action-canvas').click(150, 185)
+    cy.get('#action-canvas').click(170, 165)
 
     // click multiple elements by passing multiple: true
     cy.get('.action-labels>.label').click({ multiple: true })
@@ -117,7 +118,8 @@ context('Actions', () => {
 
     // Our app has a listener on 'dblclick' event in our 'scripts.js'
     // that hides the div and shows an input on double click
-    cy.get('.action-div').dblclick().should('not.be.visible')
+    cy.get('.action-div').dblclick()
+    cy.get('.action-div').should('not.be.visible')
     cy.get('.action-input-hidden').should('be.visible')
   })
 
@@ -126,7 +128,8 @@ context('Actions', () => {
 
     // Our app has a listener on 'contextmenu' event in our 'scripts.js'
     // that hides the div and shows an input on right click
-    cy.get('.rightclick-action-div').rightclick().should('not.be.visible')
+    cy.get('.rightclick-action-div').rightclick()
+    cy.get('.rightclick-action-div').should('not.be.visible')
     cy.get('.rightclick-action-input-hidden').should('be.visible')
   })
 
@@ -135,26 +138,26 @@ context('Actions', () => {
 
     // By default, .check() will check all
     // matching checkbox or radio elements in succession, one after another
-    cy.get('.action-checkboxes [type="checkbox"]').not('[disabled]')
-      .check().should('be.checked')
+    cy.get('.action-checkboxes [type="checkbox"]').not('[disabled]').check()
+    cy.get('.action-checkboxes [type="checkbox"]').not('[disabled]').should('be.checked')
 
-    cy.get('.action-radios [type="radio"]').not('[disabled]')
-      .check().should('be.checked')
+    cy.get('.action-radios [type="radio"]').not('[disabled]').check()
+    cy.get('.action-radios [type="radio"]').not('[disabled]').should('be.checked')
 
     // .check() accepts a value argument
-    cy.get('.action-radios [type="radio"]')
-      .check('radio1').should('be.checked')
+    cy.get('.action-radios [type="radio"]').check('radio1')
+    cy.get('.action-radios [type="radio"]').should('be.checked')
 
     // .check() accepts an array of values
-    cy.get('.action-multiple-checkboxes [type="checkbox"]')
-      .check(['checkbox1', 'checkbox2']).should('be.checked')
+    cy.get('.action-multiple-checkboxes [type="checkbox"]').check(['checkbox1', 'checkbox2'])
+    cy.get('.action-multiple-checkboxes [type="checkbox"]').should('be.checked')
 
     // Ignore error checking prior to checking
-    cy.get('.action-checkboxes [disabled]')
-      .check({ force: true }).should('be.checked')
+    cy.get('.action-checkboxes [disabled]').check({ force: true })
+    cy.get('.action-checkboxes [disabled]').should('be.checked')
 
-    cy.get('.action-radios [type="radio"]')
-      .check('radio3', { force: true }).should('be.checked')
+    cy.get('.action-radios [type="radio"]').check('radio3', { force: true })
+    cy.get('.action-radios [type="radio"]').should('be.checked')
   })
 
   it('.uncheck() - uncheck a checkbox element', () => {
@@ -164,21 +167,32 @@ context('Actions', () => {
     // checkbox elements in succession, one after another
     cy.get('.action-check [type="checkbox"]')
       .not('[disabled]')
-      .uncheck().should('not.be.checked')
+      .uncheck()
+    cy.get('.action-check [type="checkbox"]')
+      .not('[disabled]')
+      .should('not.be.checked')
 
     // .uncheck() accepts a value argument
     cy.get('.action-check [type="checkbox"]')
       .check('checkbox1')
-      .uncheck('checkbox1').should('not.be.checked')
+    cy.get('.action-check [type="checkbox"]')
+      .uncheck('checkbox1')
+    cy.get('.action-check [type="checkbox"][value="checkbox1"]')
+      .should('not.be.checked')
 
     // .uncheck() accepts an array of values
     cy.get('.action-check [type="checkbox"]')
       .check(['checkbox1', 'checkbox3'])
-      .uncheck(['checkbox1', 'checkbox3']).should('not.be.checked')
+    cy.get('.action-check [type="checkbox"]')
+      .uncheck(['checkbox1', 'checkbox3'])
+    cy.get('.action-check [type="checkbox"][value="checkbox1"]')
+      .should('not.be.checked')
+    cy.get('.action-check [type="checkbox"][value="checkbox3"]')
+      .should('not.be.checked')
 
     // Ignore error checking prior to unchecking
-    cy.get('.action-check [disabled]')
-      .uncheck({ force: true }).should('not.be.checked')
+    cy.get('.action-check [disabled]').uncheck({ force: true })
+    cy.get('.action-check [disabled]').should('not.be.checked')
   })
 
   it('.select() - select an option in a <select> element', () => {
@@ -196,17 +210,20 @@ context('Actions', () => {
 
     cy.get('.action-select-multiple')
       .select(['apples', 'oranges', 'bananas'])
+    cy.get('.action-select-multiple')
       // when getting multiple values, invoke "val" method first
       .invoke('val')
       .should('deep.equal', ['fr-apples', 'fr-oranges', 'fr-bananas'])
 
     // Select option(s) with matching value
     cy.get('.action-select').select('fr-bananas')
+    cy.get('.action-select')
       // can attach an assertion right away to the element
       .should('have.value', 'fr-bananas')
 
     cy.get('.action-select-multiple')
       .select(['fr-apples', 'fr-oranges', 'fr-bananas'])
+    cy.get('.action-select-multiple')
       .invoke('val')
       .should('deep.equal', ['fr-apples', 'fr-oranges', 'fr-bananas'])
 
@@ -227,6 +244,7 @@ context('Actions', () => {
 
     // scroll the button into view, as if the user had scrolled
     cy.get('#scroll-horizontal button').scrollIntoView()
+    cy.get('#scroll-horizontal button')
       .should('be.visible')
 
     cy.get('#scroll-vertical button')
@@ -234,6 +252,7 @@ context('Actions', () => {
 
     // Cypress handles the scroll direction needed
     cy.get('#scroll-vertical button').scrollIntoView()
+    cy.get('#scroll-vertical button')
       .should('be.visible')
 
     cy.get('#scroll-both button')
@@ -241,6 +260,7 @@ context('Actions', () => {
 
     // Cypress knows to scroll to the right and down
     cy.get('#scroll-both button').scrollIntoView()
+    cy.get('#scroll-both button')
       .should('be.visible')
   })
 
@@ -255,7 +275,9 @@ context('Actions', () => {
     // the value and trigger the 'change' event
     cy.get('.trigger-input-range')
       .invoke('val', 25)
+    cy.get('.trigger-input-range')
       .trigger('change')
+    cy.get('.trigger-input-range')
       .get('input[type=range]').siblings('p')
       .should('have.text', '25')
   })
diff --git a/cypress/e2e/2-advanced-examples/cookies.cy.js b/cypress/e2e/2-advanced-examples/cookies.cy.js
index 55c8ff482..03672f214 100644
--- a/cypress/e2e/2-advanced-examples/cookies.cy.js
+++ b/cypress/e2e/2-advanced-examples/cookies.cy.js
@@ -82,7 +82,8 @@ context('Cookies', () => {
     cy.getCookie('token').should('have.property', 'value', '123ABC')
 
     // cy.clearCookies() yields null
-    cy.clearCookie('token').should('be.null')
+    cy.clearCookie('token')
+    cy.getCookie('token').should('be.null')
 
     cy.getCookie('token').should('be.null')
   })
diff --git a/cypress/e2e/2-advanced-examples/misc.cy.js b/cypress/e2e/2-advanced-examples/misc.cy.js
index 8c213e1db..0e15cb611 100644
--- a/cypress/e2e/2-advanced-examples/misc.cy.js
+++ b/cypress/e2e/2-advanced-examples/misc.cy.js
@@ -12,7 +12,8 @@ context('Misc', () => {
     // and force Cypress to re-query from the root element
     cy.get('.misc-table').within(() => {
       // ends the current chain and yields null
-      cy.contains('Cheryl').click().end()
+      cy.contains('Cheryl').click()
+      //.end()
 
       // queries the entire table again
       cy.contains('Charles').click()
diff --git a/cypress/e2e/2-advanced-examples/spies_stubs_clocks.cy.js b/cypress/e2e/2-advanced-examples/spies_stubs_clocks.cy.js
index aac6c3f20..e148094c6 100644
--- a/cypress/e2e/2-advanced-examples/spies_stubs_clocks.cy.js
+++ b/cypress/e2e/2-advanced-examples/spies_stubs_clocks.cy.js
@@ -76,6 +76,7 @@ context('Spies, Stubs, and Clock', () => {
     cy.clock(now)
     cy.visit('http://localhost:8080/commands/spies-stubs-clocks')
     cy.get('#clock-div').click()
+    cy.get('#clock-div')
       .should('have.text', '1489449600')
   })
 
@@ -89,10 +90,12 @@ context('Spies, Stubs, and Clock', () => {
     cy.clock(now)
     cy.visit('http://localhost:8080/commands/spies-stubs-clocks')
     cy.get('#tick-div').click()
+    cy.get('#tick-div')
       .should('have.text', '1489449600')
 
     cy.tick(10000) // 10 seconds passed
     cy.get('#tick-div').click()
+    cy.get('#tick-div')
       .should('have.text', '1489449610')
   })
 
diff --git a/cypress/e2e/2-advanced-examples/storage.cy.js b/cypress/e2e/2-advanced-examples/storage.cy.js
index 389a9f2d0..dd7639572 100644
--- a/cypress/e2e/2-advanced-examples/storage.cy.js
+++ b/cypress/e2e/2-advanced-examples/storage.cy.js
@@ -10,43 +10,48 @@ context('Local Storage / Session Storage', () => {
 
   it('cy.clearLocalStorage() - clear all data in localStorage for the current origin', () => {
     // https://on.cypress.io/clearlocalstorage
-    cy.get('.ls-btn').click().should(() => {
+    cy.get('.ls-btn').click()
+    cy.get('.ls-btn').should(() => {
       expect(localStorage.getItem('prop1')).to.eq('red')
       expect(localStorage.getItem('prop2')).to.eq('blue')
       expect(localStorage.getItem('prop3')).to.eq('magenta')
     })
 
-    // clearLocalStorage() yields the localStorage object
-    cy.clearLocalStorage().should((ls) => {
-      expect(ls.getItem('prop1')).to.be.null
-      expect(ls.getItem('prop2')).to.be.null
-      expect(ls.getItem('prop3')).to.be.null
+    cy.clearLocalStorage()
+    cy.getAllLocalStorage().should(() => {
+      expect(localStorage.getItem('prop1')).to.be.null
+      expect(localStorage.getItem('prop2')).to.be.null
+      expect(localStorage.getItem('prop3')).to.be.null
     })
 
-    cy.get('.ls-btn').click().should(() => {
+    cy.get('.ls-btn').click()
+    cy.get('.ls-btn').should(() => {
       expect(localStorage.getItem('prop1')).to.eq('red')
       expect(localStorage.getItem('prop2')).to.eq('blue')
       expect(localStorage.getItem('prop3')).to.eq('magenta')
     })
 
     // Clear key matching string in localStorage
-    cy.clearLocalStorage('prop1').should((ls) => {
-      expect(ls.getItem('prop1')).to.be.null
-      expect(ls.getItem('prop2')).to.eq('blue')
-      expect(ls.getItem('prop3')).to.eq('magenta')
+    cy.clearLocalStorage('prop1')
+    cy.getAllLocalStorage().should(() => {
+      expect(localStorage.getItem('prop1')).to.be.null
+      expect(localStorage.getItem('prop2')).to.eq('blue')
+      expect(localStorage.getItem('prop3')).to.eq('magenta')
     })
 
-    cy.get('.ls-btn').click().should(() => {
+    cy.get('.ls-btn').click()
+    cy.get('.ls-btn').should(() => {
       expect(localStorage.getItem('prop1')).to.eq('red')
       expect(localStorage.getItem('prop2')).to.eq('blue')
       expect(localStorage.getItem('prop3')).to.eq('magenta')
     })
 
     // Clear keys matching regex in localStorage
-    cy.clearLocalStorage(/prop1|2/).should((ls) => {
-      expect(ls.getItem('prop1')).to.be.null
-      expect(ls.getItem('prop2')).to.be.null
-      expect(ls.getItem('prop3')).to.eq('magenta')
+    cy.clearLocalStorage(/prop1|2/)
+    cy.getAllLocalStorage().should(() => {
+      expect(localStorage.getItem('prop1')).to.be.null
+      expect(localStorage.getItem('prop2')).to.be.null
+      expect(localStorage.getItem('prop3')).to.eq('magenta')
     })
   })
 
@@ -72,10 +77,11 @@ context('Local Storage / Session Storage', () => {
     cy.get('.ls-btn').click()
 
     // clearAllLocalStorage() yields null
-    cy.clearAllLocalStorage().should(() => {
-      expect(sessionStorage.getItem('prop1')).to.be.null
-      expect(sessionStorage.getItem('prop2')).to.be.null
-      expect(sessionStorage.getItem('prop3')).to.be.null
+    cy.clearAllLocalStorage()
+    cy.getAllLocalStorage().should(() => {
+      expect(localStorage.getItem('prop1')).to.be.null
+      expect(localStorage.getItem('prop2')).to.be.null
+      expect(localStorage.getItem('prop3')).to.be.null
     })
   })
 
@@ -101,7 +107,8 @@ context('Local Storage / Session Storage', () => {
     cy.get('.ls-btn').click()
 
     // clearAllSessionStorage() yields null
-    cy.clearAllSessionStorage().should(() => {
+    cy.clearAllSessionStorage()
+    cy.getAllSessionStorage().should(() => {
       expect(sessionStorage.getItem('prop4')).to.be.null
       expect(sessionStorage.getItem('prop5')).to.be.null
       expect(sessionStorage.getItem('prop6')).to.be.null
diff --git a/cypress/e2e/2-advanced-examples/utilities.cy.js b/cypress/e2e/2-advanced-examples/utilities.cy.js
index f31b1b204..a7c7a3479 100644
--- a/cypress/e2e/2-advanced-examples/utilities.cy.js
+++ b/cypress/e2e/2-advanced-examples/utilities.cy.js
@@ -19,10 +19,9 @@ context('Utilities', () => {
     // https://on.cypress.io/$
     let $li = Cypress.$('.utility-jquery li:first')
 
-    cy.wrap($li)
-      .should('not.have.class', 'active')
-      .click()
-      .should('have.class', 'active')
+    cy.wrap($li).should('not.have.class', 'active')
+    cy.wrap($li).click()
+    cy.wrap($li).should('have.class', 'active')
   })
 
   it('Cypress.Blob - blob utilities and base64 string conversion', () => {
@@ -41,7 +40,7 @@ context('Utilities', () => {
         $div.append(img)
 
         cy.get('.utility-blob img').click()
-          .should('have.attr', 'src', dataUrl)
+        cy.get('.utility-blob img').should('have.attr', 'src', dataUrl)
       })
     })
   })