fix: add remote.active-protocols argument and set it to 2 to enable CDP #29720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
fix/firefox_nightly_129_launch
branch
from
f358e10
to
5b0dc25
Compare
AtofStryker
force-pushed
the
fix/firefox_nightly_129_launch
branch
from
5b0dc25
to
247403b
Compare
11 flaky tests on run #55858 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Launchpad: Open Mode > opens an e2e project without a supportFile |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > can timeout when retrieving upstream response |
Test Replay
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt just a digit |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws after timing out after a .wait() alias reference |
Test Replay
|
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
Review all test suite changes for PR #29720 ↗︎
jennifer-shehane
approved these changes
Jun 20, 2024
ryanthemanuel
approved these changes
Jun 20, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR allows for Firefox 129 and up (Currently Firefox Nightly) to run with Cypress. CDP has been deprecated with Firefox 129, which is scheduled to release around early August. To handle this, we need to enable CDP via the
'remote.active-protocols': 2,browser argumentSteps to test
Download Firefox Nightly and make sure cypress can run (via open or run mode) with firefox as the target browser.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?