Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with a real HCS OME-TIFF dataset #163

Open
ziw-liu opened this issue Jul 24, 2023 · 5 comments
Open

Test with a real HCS OME-TIFF dataset #163

ziw-liu opened this issue Jul 24, 2023 · 5 comments
Labels
CI Continuous integration μManager Micro-Manager files and metadata

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Jul 24, 2023

          I'm looking at this now, I can make you a small test dataset

EDIT: Check if this fits the bill: cm.mantis/2023_07_21_mm_hsc_dataset/mm_hsc_dataset_2

Originally posted by @ieivanov in #159 (comment)

@ziw-liu ziw-liu added μManager Micro-Manager files and metadata CI Continuous integration labels Jul 24, 2023
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jul 24, 2023

@ieivanov thanks for making this! I think this is a nice example to test against. One very minor point is that it would be nice to have non-single digit column numbers (e.g. 12) to prevent future regressions.

@ieivanov
Copy link
Contributor

Yup, I can make that happen. I'll have to re-acquire this dataset anyway as we saw that the data is of the wrong file size due to a MM bug somewhere (micro-manager/micro-manager#1746)

@ieivanov
Copy link
Contributor

One wrinkle we missed yesterday - an important feature of the iohub readers is adding singleton dimensions where they may be missing. In the test data we should include acquisitions with fewer than 5 dimensions to test that iohub correctly turns those into TCZYX datasets

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jul 25, 2023

In the test data we should include acquisitions with fewer than 5 dimensions to test that iohub correctly turns those into TCZYX datasets

This is already tested with the older (2020-gamma) MM datasets. I don't think we need to acquire the full suite of the combinations unless we aim to replace the old ones completely.

@ieivanov
Copy link
Contributor

Ah, right, OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration μManager Micro-Manager files and metadata
Projects
None yet
Development

No branches or pull requests

2 participants