-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with High DPI support in latest CEF on Windows #358
Comments
When custom scaling is set to 132% in Windows 10, calling |
Both main process and subprocesses are now set to be DPI aware when cef.DpiAware.EnableHighDpiSupport function is called. - Update docs/MigrationGuide.md document. - Update examples/wxpython.py - Add DpiAware.EnableHighDpiSupport function. - Deprecate DpiAware.SetProcessDpiAware function. - Deprecate ApplicationSettings.auto_zooming "system_dpi" value
Both main process and subprocesses are now set to be DPI aware when cef.DpiAware.EnableHighDpiSupport function is called. - Update docs/MigrationGuide.md document. - Update examples/wxpython.py - Add DpiAware.EnableHighDpiSupport function. - Deprecate DpiAware.SetProcessDpiAware function. - Deprecate ApplicationSettings.auto_zooming "system_dpi" value
Fixed in cefpython57 branch in commit 331bfb5 and in master branch in commit ebdb184. See Migration Guide document for new changes: Both main process and subprocesses are now set to be DPI aware when cef.DpiAware.EnableHighDpiSupport function is called. Updated wxpython.py example. |
Hi - not sure whether to post here or create a new issues, but appear to be encountering a regression in relation to this on cefpython3 66 / Windows 10 / 4k screen I'm packaging a flask/dash app -- was initially using cefpython3 directly with a window launcher based on the pywin32 example, but now using it via pywebview instead. The problem is evident using either approach. |
@cormacc Does the issue reproduce with the original wxpython.py example? https://github.com/cztomczak/cefpython/blob/master/examples/wxpython.py It's best to report problems on the forum. |
I'm afraid it does. Steps taken to reproduce below, but I'll duplicate them in that forum thread. Or would you prefer I post under a new topic? Steps to reproduce:
Laptop is fairly mainstream -- a Thinkpad T580 with the high def screen option, running Windows 10 Pro |
@cormacc This is issue tracker. Please create a topic on the forum so we can discuss your problem further. Provide more details on your issue. In the referenced CEF topic the reporter said his issue was resolved by adding DPI awareness manifest. |
High DPI was last tested by me in the v31 release. There were some changes in upstream CEF in regards to High DPI support. For example in phpdesktop it was no more required to change zoom level according to OS DPI settings.
SetProcessDpiAware code was commented out in phpdesktop:
https://github.com/cztomczak/phpdesktop/blob/c00988f69348b73b6dee27bdf45d145b719e2a3d/phpdesktop-chrome39/dpi_aware.cpp#L14
CEF Python has the same code. It needs to be checked whether this needs to be commented out as well:
cefpython/src/client_handler/dpi_aware.cpp
Line 163 in 824d7ce
In the wxpython.py example you can see this code that enables High DPI support:
PHP Desktop embeds DPI aware manifest by default:
https://github.com/cztomczak/phpdesktop/blob/master/phpdesktop-chrome57/DeclareDPIAware.manifest
The text was updated successfully, but these errors were encountered: