Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

No logs written in case of crash #32

Open
andre2007 opened this issue Feb 28, 2019 · 1 comment
Open

No logs written in case of crash #32

andre2007 opened this issue Feb 28, 2019 · 1 comment

Comments

@andre2007
Copy link

I use Dls within IntelliJ using LSP plugin. LSP notifies me in case Dls is crashing. Unfortunately the Dls log file does not contain any information about the crash. Actually the log does not even indicate that a crash occurred.

Could you check whether you could write exception stack trace to the log file?

@LaurentTreguier
Copy link
Member

When DLS crashes, it's because of an Error, all Exceptions are handled as "internal errors".
So by default, I simply let DLS die a horrible death when it happens, since doing anything after an Error has been thrown is potentially unsafe.
Since #12, there is a catchErrors initialization option, that actually lets DLS catche errors too. I would tend to argue that it could be the role of the client to check the process' stderr when it crashes though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants