Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.0 possible bug for condition for stopAnimation #46

Open
PhilFlash opened this issue Nov 24, 2015 · 2 comments
Open

V2.0.0 possible bug for condition for stopAnimation #46

PhilFlash opened this issue Nov 24, 2015 · 2 comments

Comments

@PhilFlash
Copy link

Hi,
In the new version 2.0.0, you have in line 127:

scrollHeight = document.body.scrollheight;

The correct attribute is: scrollHeight (H in uppercase). It's ok in version 1.1.7:

scrollHeight = document.body.scrollHeight;

Not a bug but for condition 1 and 2, use '===' (instead ==) in line 123 et 125,

if (
    ( // condition 1
        position === endLocation
    ) ||
    ( // condition 2
        currentLocation === endLocation
    ) ||

Philippe

@houmark
Copy link

houmark commented Jan 8, 2016

+1 - would be nice with a quick fix as this one is keeping us from upgrading to 2.0.

@rickerd
Copy link

rickerd commented Aug 13, 2016

When i use 2.0 instead of 1.1.7 it has this behaviour;
(on iPhone)

  • Button clicked
    • Browser scrolls to anchorpoint
  • User scrolls a little up to see the button again and clicks on it
    • Browser scrolls up but stops to scroll down

With version 2.0 it has the same functionality as shown above only it scrolls also down again.
I don't know if any other people have this?
Now it flicks the browser scroll around from bottom to top and bottom again. It isn't a nice animation now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants