[Code Quality]: Tooling & .NET 4.8 migration #773
-
|
https://github.com/unquietwiki/ImageGlass/tree/develop Since I've used this program for 2-3 years now and was just looking at another program I use regularly, I figured I'd take a crack at making some codebase improvements. Here's what I'm going for...
Sharpen can't yet do its refactorings automatically; it leans on user interaction + VS Code's own refactoring suggestions. The C# 5.0 & 8.0 refactorings are more involved because they involve async & null changes; the rest involve more basic changes, that have a less disruptive impact. I've done some of the work, but there remains much to do. I have other stuff I need to work on, so I don't want to put too much time into this if it's not going to be of use. Please advise. Thanks! |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 14 replies
-
|
@d2phap BTW thank you for answering my previous question a while back about adding a codec. Since this is your work, I'd like your thoughts on this. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @unquietwiki It's good to know you want to refactor and clean up the code. Actually, I have plan to move IG from WinForms to WPF with .NET 5; this will take long time! Please feel free to create small pull requests of refactoring. I'm happy to merge it. |
Beta Was this translation helpful? Give feedback.
-
|
@d2phap Thanks! I'll pull the first set now for your consideration. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I didn't mention that there is config file for formatting at https://github.com/d2phap/ImageGlass/blob/master/Source/.editorconfig and the external projects should not be cleaned up |
Beta Was this translation helpful? Give feedback.
-
|
Acknowledged. Are you able to try the tools I'm using with your current
workflow & can compare results? I'm probably not going to get anything done
on this for another 12-24hr.
…On Mon, May 4, 2020, 1:46 AM Phap Dieu Duong ***@***.***> wrote:
Sorry, I didn't mention that there is config file for formatting at
https://github.com/d2phap/ImageGlass/blob/master/Source/.editorconfig
and the external projects should not be cleaned up
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#773 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHV7PYA4MZ74VS5657QX6TRPZ6F7ANCNFSM4MYCTRPA>
.
|
Beta Was this translation helpful? Give feedback.
-
|
Thank you, I mostly work on IG during weekend |
Beta Was this translation helpful? Give feedback.
-
|
Hey @d2phap . I'll close #775 & try again to lay down basic refactoring, based on the following...
ImageGlass.ImageBox and ImageGlass.ImageListView: you mentioned them as "external projects" you didn't want to mess with. I wasn't sure if they were in your repo, or not. How do you want to handle anything with those, that might be an issue? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @unquietwiki Thank you, I have been very busy with my current job.
These are the customised repos, and added in ImageGlass folder. I sometimes still look into the old source code to investigate somethings. |
Beta Was this translation helpful? Give feedback.
-
|
@d2phap Acknowledged on the repos you identified. As for Codacy, they apparently support free use up to 4 users per https://www.codacy.com/pricing (I have it on for a couple of my own Github repos). I hear you on the work; that's happened to me over the years. I don't even have a regular job ATM (obviously the Pandemic's a factor), but the family keeps me on my toes since they're still busy! Also looking into Javascript dev as well. Hope you're keeping well. |
Beta Was this translation helpful? Give feedback.
-
|
@d2phap Hey there, hope things are going alright for you. I finally had a chance to do what we discussed and tried out the agreed-upon changes on the master branch. Seems to run pretty smoothly. Can you please let me know how you want this handled going forward? I imagine you'd want to have a branch set up to merge to, that we could finish up work on with your more recent updates? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot @unquietwiki |
Beta Was this translation helpful? Give feedback.
-
|
Follow-up: noting for the record that #813 had additional refactoring completed. |
Beta Was this translation helpful? Give feedback.
-
|
thanks a lot! |
Beta Was this translation helpful? Give feedback.
-
|
@d2phap No problem! You won't believe how many random images + my own photography I have to manage. Heh. |
Beta Was this translation helpful? Give feedback.
-
|
Don't say it's a million 😵 |
Beta Was this translation helpful? Give feedback.
-
|
@d2phap (counts) 11K in RAW + JPG for photos; another 11K+ in random crap I've found over the past 20 years. I used to run a BBS in High School when Internet was becoming a thing. Ah dial-up. |
Beta Was this translation helpful? Give feedback.
@d2phap Hey there, hope things are going alright for you. I finally had a chance to do what we discussed and tried out the agreed-upon changes on the master branch. Seems to run pretty smoothly. Can you please let me know how you want this handled going forward? I imagine you'd want to have a branch set up to merge to, that we could finish up work on with your more recent updates? Thanks.