Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#wish #3

Open
agborkowski opened this issue Feb 10, 2012 · 4 comments
Open

#wish #3

agborkowski opened this issue Feb 10, 2012 · 4 comments
Labels
feature request

Comments

@agborkowski
Copy link

http://socket.io/ port server for node.native
@d5
Copy link
Owner

d5 commented Feb 10, 2012

Thanks for your idea. I will keep this in my to-do list.
BTW, what do you think, @guille?

@rauchg
Copy link

rauchg commented Feb 10, 2012

Absolutely. We should start with http://github.com/learnboost/engine.io, which is the core dependency of the upcoming socket.io 1.0. The luvit team already did their engine port.

@larroy
Copy link

larroy commented Feb 13, 2012

The deletes in stream.h for example would cause a leak if the callback throws.

@d5
Copy link
Owner

d5 commented Feb 13, 2012

Thanks. I'll review and fix them soon.

@littletree-github littletree-github mentioned this issue Feb 20, 2012
Closed
kennethho pushed a commit to kennethho/node.native that referenced this issue Dec 17, 2012
@bnoordhuis
unix: undo changes to uv_set_process_title()
69a6afe 
It's making node.js crash when run as root. Backtrace:

  (gdb) bt
  #0  0x00007fff856e3ff9 in __findenv ()
  d5#1  0x00007fff856e404c in getenv ()
  d5#2  0x000000010004c850 in loop_init (loop=0x10045a792, flags=8) at ev.c:1707
  d5#3  0x000000010004cb3b in ev_backend [inlined] () at /Users/tjfontaine/Development/node/deps/uv/src/unix/ev/ev.c:2090
  d5#4  0x000000010004cb3b in ev_default_loop (flags=1606417108) at ev.c:2092
  d5#5  0x000000010004e5c6 in uv__loop_init (loop=0x10066e330, default_loop=1) at loop.c:52
  d5#6  0x0000000100044367 in uv_default_loop () at core.c:196
  d5#7  0x0000000100004625 in node::Init (argc=1606417456, argv=0x100b0f490) at node.cc:2761
  d5#8  0x000000010000797d in node::Start (argc=1606417600, argv=0x0) at node.cc:2888
  d5#9  0x0000000100000ca4 in start ()

This reverts commits:

  b49d6f7 unix: fix uv_set_process_title()
  a9f6f06 unix: fix format string vulnerability in freebsd.c
  a87abc7 unix: avoid buffer overflow in proctitle.c
  dc97d44 unix: move uv_set_process_title() to proctitle.c
@hmonfared hmonfared mentioned this issue Nov 10, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rauchg @agborkowski @larroy @d5