From 3a984c13a2f3cccb7bff33b624186bf1eee5c995 Mon Sep 17 00:00:00 2001 From: Johann Miller Date: Thu, 2 Nov 2023 16:06:13 -0400 Subject: [PATCH] remove executions resolver on GrapheneAssetCheck --- .../ui-core/src/graphql/schema.graphql | 1 - .../packages/ui-core/src/graphql/types.ts | 7 ------- .../dagster_graphql/schema/asset_checks.py | 20 ------------------- 3 files changed, 28 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql b/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql index 6477ed6df2171..5fd142f14005e 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql +++ b/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql @@ -865,7 +865,6 @@ type AssetCheck { name: String! assetKey: AssetKey! description: String - executions(limit: Int!, cursor: String): [AssetCheckExecution!]! executionForLatestMaterialization: AssetCheckExecution canExecuteIndividually: AssetCheckCanExecuteIndividually! } diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts b/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts index 1b8227f185427..82ebebe5e07a7 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts +++ b/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts @@ -130,15 +130,9 @@ export type AssetCheck = { canExecuteIndividually: AssetCheckCanExecuteIndividually; description: Maybe; executionForLatestMaterialization: Maybe; - executions: Array; name: Scalars['String']; }; -export type AssetCheckExecutionsArgs = { - cursor?: InputMaybe; - limit: Scalars['Int']; -}; - export enum AssetCheckCanExecuteIndividually { CAN_EXECUTE = 'CAN_EXECUTE', NEEDS_USER_CODE_UPGRADE = 'NEEDS_USER_CODE_UPGRADE', @@ -4637,7 +4631,6 @@ export const buildAssetCheck = ( : relationshipsToOmit.has('AssetCheckExecution') ? ({} as AssetCheckExecution) : buildAssetCheckExecution({}, relationshipsToOmit), - executions: overrides && overrides.hasOwnProperty('executions') ? overrides.executions! : [], name: overrides && overrides.hasOwnProperty('name') ? overrides.name! : 'dignissimos', }; }; diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/asset_checks.py b/python_modules/dagster-graphql/dagster_graphql/schema/asset_checks.py index 96ae1554c7451..44d9e5e7d5306 100644 --- a/python_modules/dagster-graphql/dagster_graphql/schema/asset_checks.py +++ b/python_modules/dagster-graphql/dagster_graphql/schema/asset_checks.py @@ -132,12 +132,6 @@ class GrapheneAssetCheck(graphene.ObjectType): name = graphene.NonNull(graphene.String) assetKey = graphene.NonNull(GrapheneAssetKey) description = graphene.String() - # deprecated. Use the top level assetCheckExecutions resolver instead - executions = graphene.Field( - non_null_list(GrapheneAssetCheckExecution), - limit=graphene.NonNull(graphene.Int), - cursor=graphene.String(), - ) executionForLatestMaterialization = graphene.Field(GrapheneAssetCheckExecution) canExecuteIndividually = graphene.NonNull(GrapheneAssetCheckCanExecuteIndividually) @@ -163,20 +157,6 @@ def resolve_name(self, _) -> str: def resolve_description(self, _) -> Optional[str]: return self._asset_check.description - def resolve_executions( - self, graphene_info: ResolveInfo, **kwargs - ) -> List[GrapheneAssetCheckExecution]: - from dagster_graphql.implementation.fetch_asset_checks import ( - fetch_asset_check_executions, - ) - - return fetch_asset_check_executions( - graphene_info.context.instance, - self._asset_check.key, - kwargs["limit"], - kwargs.get("cursor"), - ) - def resolve_executionForLatestMaterialization( self, _graphene_info: ResolveInfo ) -> Optional[GrapheneAssetCheckExecution]: