From 706b0e594a8903f783651583287c9c05e9e47ba0 Mon Sep 17 00:00:00 2001 From: Nick Schrock Date: Mon, 9 Oct 2023 13:26:54 -0400 Subject: [PATCH] change non-executable to external --- .../packages/ui-core/src/assets/AssetNodeDefinition.tsx | 2 +- .../ui-core/src/assets/LaunchAssetExecutionButton.tsx | 4 ++-- .../src/assets/__tests__/LaunchAssetExecutionButton.test.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx index 499b151a2bfcb..4a29e0d66aa02 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx @@ -298,7 +298,7 @@ const DescriptionAnnotations: React.FC<{ {assetNode.isSource ? ( Source Asset ) : !assetNode.isExecutable ? ( - Non-executable Asset + External Asset ) : undefined} ); diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx index 3c56cad640fe0..f781b65617da2 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx @@ -166,7 +166,7 @@ export function executionDisabledMessageForAssets( : assets.every((a) => a.isSource) ? 'Source assets cannot be materialized' : assets.every((a) => !a.isExecutable) - ? 'Non-executable assets cannot be materialized' + ? 'External assets cannot be materialized' : null; } @@ -412,7 +412,7 @@ async function stateForLaunchingAssets( if (assets.some((x) => !x.isExecutable)) { return { type: 'error', - error: 'One or more non-executable assets are selected.', + error: 'One or more external assets are selected.', }; } diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx index 0a3b3a34974bd..cf48c31457fe1 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx @@ -129,7 +129,7 @@ describe('LaunchAssetExecutionButton', () => { expect(button).toBeDisabled(); userEvent.hover(button); - expect(await screen.findByText('Non-executable assets cannot be materialized')).toBeDefined(); + expect(await screen.findByText('External assets cannot be materialized')).toBeDefined(); }); });