From 9809baa9791d7e36e93a65edb37b4a41419a3f38 Mon Sep 17 00:00:00 2001 From: Marco polo Date: Wed, 28 Aug 2024 12:55:13 -0400 Subject: [PATCH] Update eslint-config package version (#24013) ## Summary & Motivation Also add the one exception to the newly added rule ## How I Tested These Changes ## Changelog [New | Bug | Docs] NOCHANGELOG --- .../packages/app-oss/src/NUX/CommunityNux.tsx | 2 +- .../packages/app-oss/src/telemetryLink.tsx | 2 +- .../packages/eslint-config/CHANGES.md | 4 +++ .../packages/eslint-config/package.json | 2 +- .../ui-core/src/apollo-client/index.tsx | 2 +- js_modules/dagster-ui/yarn.lock | 30 ++++++++++++++++++- 6 files changed, 37 insertions(+), 5 deletions(-) diff --git a/js_modules/dagster-ui/packages/app-oss/src/NUX/CommunityNux.tsx b/js_modules/dagster-ui/packages/app-oss/src/NUX/CommunityNux.tsx index d498e7b0e0fc2..fbe3f57bdd425 100644 --- a/js_modules/dagster-ui/packages/app-oss/src/NUX/CommunityNux.tsx +++ b/js_modules/dagster-ui/packages/app-oss/src/NUX/CommunityNux.tsx @@ -1,4 +1,3 @@ -import {gql, useMutation, useSuspenseQuery} from '@apollo/client'; import { Body, Box, @@ -12,6 +11,7 @@ import { Spinner, TextInput, } from '@dagster-io/ui-components'; +import {gql, useMutation, useSuspenseQuery} from '@dagster-io/ui-core/apollo-client'; import {useStateWithStorage} from '@dagster-io/ui-core/hooks/useStateWithStorage'; import * as React from 'react'; import isEmail from 'validator/lib/isEmail'; diff --git a/js_modules/dagster-ui/packages/app-oss/src/telemetryLink.tsx b/js_modules/dagster-ui/packages/app-oss/src/telemetryLink.tsx index 27f37fdb26a3e..983ce0f06e3e3 100644 --- a/js_modules/dagster-ui/packages/app-oss/src/telemetryLink.tsx +++ b/js_modules/dagster-ui/packages/app-oss/src/telemetryLink.tsx @@ -1,4 +1,4 @@ -import {ApolloLink} from '@apollo/client'; +import {ApolloLink} from '@dagster-io/ui-core/apollo-client'; import {TelemetryAction, logTelemetry} from '@dagster-io/ui-core/app/Telemetry'; const TELEMETRY_WHITELIST = new Set([ diff --git a/js_modules/dagster-ui/packages/eslint-config/CHANGES.md b/js_modules/dagster-ui/packages/eslint-config/CHANGES.md index 3bcf884d598de..6c7bf0ad4df36 100644 --- a/js_modules/dagster-ui/packages/eslint-config/CHANGES.md +++ b/js_modules/dagster-ui/packages/eslint-config/CHANGES.md @@ -1,3 +1,7 @@ +## 1.0.16 (August 28, 2024) + +- Added no-apollo-client rule. + ## 1.0.15 (April 23, 2024) - Dependency upgrades diff --git a/js_modules/dagster-ui/packages/eslint-config/package.json b/js_modules/dagster-ui/packages/eslint-config/package.json index ad548b8cb926a..07aa391b88ef3 100644 --- a/js_modules/dagster-ui/packages/eslint-config/package.json +++ b/js_modules/dagster-ui/packages/eslint-config/package.json @@ -1,6 +1,6 @@ { "name": "@dagster-io/eslint-config", - "version": "1.0.15", + "version": "1.0.16", "description": "Shared eslint configuration for @dagster-io", "license": "Apache-2.0", "main": "index.js", diff --git a/js_modules/dagster-ui/packages/ui-core/src/apollo-client/index.tsx b/js_modules/dagster-ui/packages/ui-core/src/apollo-client/index.tsx index a2796a4a85ee4..aaa595f224f9c 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/apollo-client/index.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/apollo-client/index.tsx @@ -1,4 +1,4 @@ -/* eslint-disable no-restricted-imports */ +/* eslint-disable no-restricted-imports, dagster-rules/no-apollo-client */ import { LazyQueryHookOptions, OperationVariables, diff --git a/js_modules/dagster-ui/yarn.lock b/js_modules/dagster-ui/yarn.lock index 76117b60cf93c..f63f1e2354cab 100644 --- a/js_modules/dagster-ui/yarn.lock +++ b/js_modules/dagster-ui/yarn.lock @@ -3596,7 +3596,29 @@ __metadata: languageName: unknown linkType: soft -"@dagster-io/eslint-config@npm:1.0.15, @dagster-io/eslint-config@workspace:*, @dagster-io/eslint-config@workspace:packages/eslint-config": +"@dagster-io/eslint-config@npm:1.0.15": + version: 1.0.15 + resolution: "@dagster-io/eslint-config@npm:1.0.15" + dependencies: + "@typescript-eslint/eslint-plugin": "npm:^7.7.1" + "@typescript-eslint/parser": "npm:^7.7.1" + eslint-config-prettier: "npm:^9.1.0" + eslint-plugin-dagster-rules: "link:./rules" + eslint-plugin-import: "npm:^2.29.1" + eslint-plugin-jest: "npm:^27.9.0" + eslint-plugin-jsx-a11y: "npm:^6.8.0" + eslint-plugin-prettier: "npm:^5.1.3" + eslint-plugin-react: "npm:^7.34.1" + eslint-plugin-react-hooks: "npm:^4.6.0" + eslint-plugin-unused-imports: "npm:^3.1.0" + peerDependencies: + eslint: ^8.57.0 + prettier: ^3.0.3 + checksum: 10/ed220390ae550ddbabfa2fe3baaa1ed631b7c5c680eeb6dfd609e90ec1caa592c34f54ffa255aa888334ac03bb7f063fa38d8d27068bebcdc1c8d4c8a54472d3 + languageName: node + linkType: hard + +"@dagster-io/eslint-config@workspace:*, @dagster-io/eslint-config@workspace:packages/eslint-config": version: 0.0.0-use.local resolution: "@dagster-io/eslint-config@workspace:packages/eslint-config" dependencies: @@ -12517,6 +12539,12 @@ __metadata: languageName: node linkType: hard +"eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40npm%3A1.0.15": + version: 0.0.0-use.local + resolution: "eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40npm%3A1.0.15" + languageName: node + linkType: soft + "eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40workspace%3Apackages%2Feslint-config": version: 0.0.0-use.local resolution: "eslint-plugin-dagster-rules@link:./rules::locator=%40dagster-io%2Feslint-config%40workspace%3Apackages%2Feslint-config"