From a908bd25895a4abe6459897940b40f7368c18fd7 Mon Sep 17 00:00:00 2001 From: JamieDeMaria Date: Tue, 12 Dec 2023 15:54:37 -0500 Subject: [PATCH] cleanup --- .../dagster/dagster/_core/execution/context/output.py | 5 ----- .../dagster/dagster/_core/execution/plan/execute_step.py | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/python_modules/dagster/dagster/_core/execution/context/output.py b/python_modules/dagster/dagster/_core/execution/context/output.py index 6ab62e8fd73a2..ca3760a4e53ca 100644 --- a/python_modules/dagster/dagster/_core/execution/context/output.py +++ b/python_modules/dagster/dagster/_core/execution/context/output.py @@ -242,11 +242,6 @@ def op_def(self) -> "OpDefinition": return cast(OpDefinition, self._op_def) - @public - @property - def has_dagster_type(self) -> bool: - return self._dagster_type is not None - @public @property def dagster_type(self) -> "DagsterType": diff --git a/python_modules/dagster/dagster/_core/execution/plan/execute_step.py b/python_modules/dagster/dagster/_core/execution/plan/execute_step.py index ac6771d40a7f4..b104168fb4a6d 100644 --- a/python_modules/dagster/dagster/_core/execution/plan/execute_step.py +++ b/python_modules/dagster/dagster/_core/execution/plan/execute_step.py @@ -717,7 +717,7 @@ def _store_output( if ( step_output.properties.asset_check_key or (step_context.output_observes_source_asset(step_output_handle.output_name)) - or output_context.dagster_type.is_nothing # TODO - maybe need to scope this to just assets + or output_context.dagster_type.is_nothing ): yield from _log_asset_materialization_events_for_asset( step_context=step_context,