From be2db9523c95f92c0c7e9478bc043bfbcd6c1007 Mon Sep 17 00:00:00 2001 From: kevin-longe-unmind Date: Fri, 9 Aug 2024 19:11:32 +0100 Subject: [PATCH] [dagster-datahub] (loosen pydantic requirement) (#23393) ## Summary & Motivation This pydantic requirement is needlessly strict give that the usage of Field is only in one file and uses only two parameters of it (both of which have not changed since the Pydantic 2.0 upgrade). This needlessly strict requirement is making it so that this won't resolve with other packages that require pydantic 2.0. Can we please loosen this restriction? ## How I Tested These Changes Used the forked repo via pip --------- Co-authored-by: Colton Padden --- .../libraries/dagster-datahub/dagster_datahub/resources.py | 1 - python_modules/libraries/dagster-datahub/setup.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/python_modules/libraries/dagster-datahub/dagster_datahub/resources.py b/python_modules/libraries/dagster-datahub/dagster_datahub/resources.py index c4f58a96d23a8..3f2aaf17e0684 100644 --- a/python_modules/libraries/dagster-datahub/dagster_datahub/resources.py +++ b/python_modules/libraries/dagster-datahub/dagster_datahub/resources.py @@ -77,7 +77,6 @@ class DatahubConnection(Config): class DatahubKafkaEmitterResource(ConfigurableResource): connection: DatahubConnection - topic: Optional[str] = None topic_routes: Dict[str, str] = Field( default={ MCE_KEY: DEFAULT_MCE_KAFKA_TOPIC, diff --git a/python_modules/libraries/dagster-datahub/setup.py b/python_modules/libraries/dagster-datahub/setup.py index 71b72540d2d7d..a83d42e37ce34 100644 --- a/python_modules/libraries/dagster-datahub/setup.py +++ b/python_modules/libraries/dagster-datahub/setup.py @@ -42,7 +42,7 @@ def get_version() -> str: f"dagster{pin}", "packaging", "requests", - "pydantic>=1.10.0,<2.0.0", + "pydantic>=1.10.0,<3.0.0", ], extras_require={}, zip_safe=False,