{execution.evaluation?.timestamp ? (
-
+
) : (
- ' - '
+
)}
|
@@ -192,7 +198,7 @@ const AssetCheckDetailModalImpl = ({
)}
|
-
+
|
@@ -255,6 +261,8 @@ export const ASSET_CHECK_EXECUTION_FRAGMENT = gql`
id
runId
status
+ stepKey
+ timestamp
evaluation {
severity
timestamp
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/AssetCheckStatusTag.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/AssetCheckStatusTag.tsx
index 32d58e08ea6b2..fedf4859850f2 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/AssetCheckStatusTag.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/AssetCheckStatusTag.tsx
@@ -2,22 +2,23 @@ import {BaseTag, Box, Colors, Icon, Spinner, Tag} from '@dagster-io/ui-component
import * as React from 'react';
import {assertUnreachable} from '../../app/Util';
-import {AssetCheckExecutionResolvedStatus, AssetCheckSeverity} from '../../graphql/types';
+import {
+ AssetCheckEvaluation,
+ AssetCheckExecution,
+ AssetCheckExecutionResolvedStatus,
+ AssetCheckSeverity,
+} from '../../graphql/types';
+import {linkToRunEvent} from '../../runs/RunUtils';
import {TagActionsPopover} from '../../ui/TagActions';
export const AssetCheckStatusTag = ({
execution,
}: {
- check: {
- name: string;
- };
- execution: {
- runId: string;
- status: AssetCheckExecutionResolvedStatus;
- evaluation?: {
- severity: AssetCheckSeverity;
- } | null;
- } | null;
+ execution:
+ | (Pick & {
+ evaluation: Pick | null;
+ })
+ | null;
}) => {
// Note: this uses BaseTag for a "grayer" style than the default tag intent
if (!execution) {
@@ -83,7 +84,10 @@ export const AssetCheckStatusTag = ({
actions={[
{
label: 'View in run logs',
- to: `/runs/${runId}`,
+ to: linkToRunEvent(
+ {id: runId},
+ {stepKey: execution.stepKey, timestamp: execution.timestamp},
+ ),
},
]}
>
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/VirtualizedAssetCheckTable.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/VirtualizedAssetCheckTable.tsx
index 3e92d34c741b6..6e83692764753 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/VirtualizedAssetCheckTable.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/VirtualizedAssetCheckTable.tsx
@@ -5,6 +5,7 @@ import * as React from 'react';
import {Link} from 'react-router-dom';
import styled from 'styled-components';
+import {linkToRunEvent} from '../../runs/RunUtils';
import {TimestampDisplay} from '../../schedules/TimestampDisplay';
import {testId} from '../../testing/testId';
import {HeaderCell, Row, RowCell, Container, Inner} from '../../ui/VirtualizedTable';
@@ -86,12 +87,17 @@ export const VirtualizedAssetCheckRow = ({assetNode, height, start, row}: AssetC
{timestamp ? (
-
+
) : (
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts
index e10f5bb9226e2..c98c59c5ae2bf 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetCheckDetailModal.types.ts
@@ -7,6 +7,8 @@ export type AssetCheckExecutionFragment = {
id: string;
runId: string;
status: Types.AssetCheckExecutionResolvedStatus;
+ stepKey: string | null;
+ timestamp: number;
evaluation: {
__typename: 'AssetCheckEvaluation';
severity: Types.AssetCheckSeverity;
@@ -151,6 +153,8 @@ export type AssetCheckDetailsQuery = {
id: string;
runId: string;
status: Types.AssetCheckExecutionResolvedStatus;
+ stepKey: string | null;
+ timestamp: number;
evaluation: {
__typename: 'AssetCheckEvaluation';
severity: Types.AssetCheckSeverity;
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts
index f4f76deefcb4e..4bddcb2ef6412 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/AssetChecks.types.ts
@@ -38,6 +38,8 @@ export type AssetChecksQuery = {
id: string;
runId: string;
status: Types.AssetCheckExecutionResolvedStatus;
+ stepKey: string | null;
+ timestamp: number;
evaluation: {
__typename: 'AssetCheckEvaluation';
severity: Types.AssetCheckSeverity;
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts
index 453f27622f713..d8f7ab9d81a3e 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/types/VirtualizedAssetCheckTable.types.ts
@@ -12,6 +12,8 @@ export type AssetCheckTableFragment = {
id: string;
runId: string;
status: Types.AssetCheckExecutionResolvedStatus;
+ stepKey: string | null;
+ timestamp: number;
evaluation: {
__typename: 'AssetCheckEvaluation';
severity: Types.AssetCheckSeverity;
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx
index 6c6a0cb812147..a7224c37a2256 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/runs/RunUtils.tsx
@@ -36,7 +36,7 @@ export function assetKeysForRun(run: {
export function linkToRunEvent(
run: {id: string},
- event: {timestamp?: string; stepKey: string | null},
+ event: {timestamp?: string | number; stepKey: string | null},
) {
return `/runs/${run.id}?${qs.stringify({
focusedTime: event.timestamp ? Number(event.timestamp) : undefined,
|