Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved display of multidimensional partitions #16999

Closed
FlightOfStairs opened this issue Oct 4, 2023 · 6 comments
Closed

Improved display of multidimensional partitions #16999

FlightOfStairs opened this issue Oct 4, 2023 · 6 comments
Assignees
Labels

Comments

@FlightOfStairs
Copy link

What's the use case?

The current catalog is awkward to use for multi-partitioned assets with high cardinality or long names. We have partitions by company and date.

Our company partition is made up of <slug>:<uuid>, e.g., mutiny-hq:c528a915-3339-4734-886d-ac3a03f65e22. The slug is a human-readable name, while uuid is required for the op. These are dynamic partitions, so we can’t easily create a static mapping from slug to ID, as new companies will be automatically added.

image

Ideas of implementation

Any of these would greatly help us:

  • Make “human readable label” a top-level thing, so the UUID doesn’t need to appear in the UI.
  • Improve column rendering - either dynamic height, or setting white-space: nowrap;.
  • Allow searching. Looks like we can filter by date, but not by company.

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@github-project-automation github-project-automation bot moved this to Untriaged in Dagster UI/UX Oct 4, 2023
@sryza sryza added the area: partitions Related to Partitions label Oct 16, 2023
@hellendag hellendag moved this from Untriaged to Core UI Meeting in Dagster UI/UX Oct 17, 2023
@hellendag
Copy link
Member

@sryza Thoughts on these suggestions?

@sryza
Copy link
Contributor

sryza commented Oct 17, 2023

Make “human readable label” a top-level thing, so the UUID doesn’t need to appear in the UI.

I wouldn't rule this out in the long term, but this change would have big implications so would like to punt on it for now.

  • Improve column rendering - either dynamic height, or setting white-space: nowrap;.

This seems like a good idea to me.

Allow searching. Looks like we can filter by date, but not by company.

This also seems like a good idea to me.

@hellendag
Copy link
Member

I'll take a look at adding some search inputs on there. It sounds like some of @salazarm's recent work may resolve the truncation and line wrapping.

@hellendag hellendag self-assigned this Oct 17, 2023
@hellendag hellendag moved this from Core UI Meeting to Soon in Dagster UI/UX Oct 17, 2023
@ztessler
Copy link

Just to note, many of these usability issues also apply in the case of singly-partitioned assets. We have several thousand dynamic partitions, with moderately long keys that tend to differ at the end of the string. It's quite difficult to find a single partition. Filtering/searching partition keys would be ideal, and the ability to increase the width of the partition key column to see the full key would also be great. Thanks!

@hellendag hellendag moved this from Soon to In progress in Dagster UI/UX Nov 7, 2023
@hellendag
Copy link
Member

@FlightOfStairs @ztessler Are you still seeing the wrapping issue? We have middle truncation in place as of #16961, so ideally that should be working correctly now.

@ztessler
Copy link

ztessler commented Nov 8, 2023

@hellendag yes, seeing middle truncation now on 1.5.6, much more usable, thanks!

@github-project-automation github-project-automation bot moved this from In progress to Done in Dagster UI/UX Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants