Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode for Dagit #1890

Closed
mgasner opened this issue Nov 5, 2019 · 13 comments
Closed

Dark mode for Dagit #1890

mgasner opened this issue Nov 5, 2019 · 13 comments
Assignees
@hellendag
Labels
area: UI/UX Related to User Interface and User Experience type: feature-request type: UI/UX usability UI/UX Usability Issue

Comments

@mgasner
Copy link
Contributor

mgasner commented Nov 5, 2019

No description provided.

@schrockn
Copy link
Member

schrockn commented Nov 5, 2019

do we really need this?

@mgasner
Copy link
Contributor Author

mgasner commented Nov 5, 2019

https://www.youtube.com/watch?v=EMB5CzzWXMQ

@mgasner mgasner added the dagit label Nov 21, 2019
@natekupp natekupp added this to the Future Release milestone Jun 1, 2020
@mgasner mgasner removed this from the Future Release milestone Oct 7, 2020
@alangenfeld alangenfeld mentioned this issue Jan 15, 2021
Closed
@braunjj
Copy link
Contributor

braunjj commented Oct 25, 2021

Community Member request:

"Usecase - I like to embed Dagit into PyCharm whilst developed & debugging pipelines. I prefer using a dark IDE theme (in the screenshot I'm using Darcula); against which I find Dagit's white background a bit jarring."

@sryza sryza removed the dagit label Nov 3, 2021
@sumaithrim
Copy link

curious - is this being actively worked on? if so, do we have a timeline?

@hellendag
Copy link
Member

This is not actively being worked on right now.

@zachmeador
Copy link

Just placing a comment for people to 👍 if there's a desire for this. Personally, I use dark mode for every possible thing I can but this is probably very low on the priorities list while dagster is still pre-v1.0.

For those that can't wait there are extensions like Dark Reader, and seems to work well enough on on dagit or the docs pages.

@forrest-bajbek
Copy link

Light-mode is like reading text on a lightbulb.

@NFeruch
Copy link

NFeruch commented Feb 5, 2023

Light-mode is like reading text on a lightbulb.

True LOL

@SomethingUseful
Copy link

SomethingUseful commented Jul 5, 2023 •
edited
Loading

It's 11pm...
MAC Theme: dark.
Gmail: dark.
SSH Console: dark.
Grafana Monitoring Panels: dark.
Coding IDE: dark.
Spotify: dark.
Slack: dark.
Opens Dagster UI: my eyes! they burn!

@hellendag hellendag moved this to Later in Dagster UI/UX Aug 8, 2023
@yuhan yuhan added area: UI/UX Related to User Interface and User Experience and removed dagit labels Aug 10, 2023
@hellendag hellendag self-assigned this Nov 21, 2023
@hellendag hellendag moved this from Later to In progress in Dagster UI/UX Nov 22, 2023
@braunjj
Copy link
Contributor

braunjj commented Nov 22, 2023

IT'S HAPPENING!

image image image

@forrest-bajbek
Copy link

THANK YOU!!!!!

@hellendag
Copy link
Member

The main PR for this change has landed (#18442) so I'm going to go ahead and close this issue.

Please feel free to contribute feedback at the GitHub discussion here: #18439

Thanks!

@github-project-automation github-project-automation bot moved this from In progress to Done in Dagster UI/UX Dec 4, 2023
@zaneselvans
Copy link

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellendag hellendag

Labels
area: UI/UX Related to User Interface and User Experience type: feature-request type: UI/UX usability UI/UX Usability Issue
Projects
Dagster UI/UX
Status: Done
Milestone
No milestone
Development

No branches or pull requests