[dagster-powerbi] Use Power BI translator instance in spec loader and state-backed defs #26734
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-c5h1z8kf0-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-powerbi
branch
from
bfdc3dc to
5d6da04
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-powerbi-asset-specs
branch
2 times, most recently
from
2274f29 to
45cdd38
Compare
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-powerbi
branch
from
22ccf98 to
adf4154
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-powerbi-asset-specs
branch
from
45cdd38 to
cc5f8b4
Compare
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-powerbi
branch
from
adf4154 to
88115b1
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-powerbi-asset-specs
branch
from
cc5f8b4 to
d3cd3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates
load_powerbi_asset_specs()and state-backed definitions to accept an instance ofDagsterPowerBITranslator.See #26133 for more details about the motivation.
How I Tested These Changes
BK
Changelog
[dagster-powerbi]
load_powerbi_asset_specsis updated to accept an instance ofDagsterPowerBITranslatoror custom subclass.