Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with local official_mnist_tf import #16

Closed
EricKolibacz opened this issue May 31, 2023 · 0 comments · Fixed by #19
Closed

Issue with local official_mnist_tf import #16

EricKolibacz opened this issue May 31, 2023 · 0 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@EricKolibacz
Copy link
Collaborator

EricKolibacz commented May 31, 2023

Description

The local poetry package official_mnist_tf within the maxi-lib package creates Problems as soon as one tries to add maxi-lib to another project.

Related to: #11
Depends on: #18

Steps to reproduce the behavior

Create a repo and add maxi-lib

poetry add git+https://github.com/dailab/MAXi-XAI-lib.git

Then try to add another package, e.g., padl

poetry add padl

You should get following error:

Path <path-to-project>/experiments/mnist for official_mnist_tf does not exist

Minimum Acceptance Criteria

  • When adding maxi-lib to a project via poetry, no error is raised
  • When adding any new package (like padl) via poetry, no error is raised
@EricKolibacz EricKolibacz added the bug Something isn't working label May 31, 2023
@EricKolibacz EricKolibacz linked a pull request May 31, 2023 that will close this issue
tuananhroman added a commit that referenced this issue May 31, 2023
…_tf-import

"official_mnist_tf" package is not a stand alone package anymore. this resolves the previous poetry issues mentioned in issue #16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants