Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Browser history navigation does not work if an alert is open #1405

Open
1 task done
atom-sgt opened this issue Sep 6, 2024 · 6 comments
Open
1 task done

Comments

@atom-sgt
Copy link

atom-sgt commented Sep 6, 2024

What went wrong? 🤔

I opened an item in my feed and clicked on the account that posted it to navigate to the account page. I hit Follow on the account. This opened an alert at the top of the page telling me that I had followed the account. I then hit the back button expecting to go have to the previous screen. The url changed, but the page did not.

Expected Behavior

I expect to return to the previous page in the history and for the page to accurately reflect the current url.

Steps to Reproduce Issue

1. Go to home page (https://app.daily.dev/)
2. Navigate to the account page of any post source (e.g. https://app.daily.dev/sources/hn)
3. Follow or unfollow the account to cause an alert to show
4. While the alert is open, click the browser back button to navigate back one page
5. Observe the url change back to the previous page (https://app.daily.dev/)
6. Observe that you are still on the account page

Solution Proposed

No response

Screenshots

No response

Environment

Win10, Firefox 129.0.2

Browsers

Firefox

OS

Windows

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@idoshamun
Copy link
Member

Hi @atom-sgt,

Unfortunately, I wasn't able to replicate your issue.
Are you able to do so constantly?

@rebelchris
Copy link
Contributor

@atom-sgt Wondering if you still experience this issue?

@atom-sgt
Copy link
Author

atom-sgt commented Nov 4, 2024

Yes, problem still exists, and yes I am able to replicate it consistently with the provided steps.

@atom-sgt
Copy link
Author

atom-sgt commented Nov 4, 2024

Testing more, navigation appears to proceed once the notification has timed out. I will create a video demonstrating this.

Navigation through the history stack is actually happening, and it is possible to move through multiple urls, but daily.dev itself will not update until the notification expires.

@atom-sgt
Copy link
Author

atom-sgt commented Nov 4, 2024

Video demonstration of navigation bug.
https://youtu.be/ruo_1cWQkH8

@rebelchris
Copy link
Contributor

@atom-sgt Wow thanks that video helps a lot!
We'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants